Fix: query service: escape dollars in collector config generated for pipelines. #4242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, using pipeline field values containing $ (eg:
attributes.$data
) breaks collector config.This happens because the collector attempts to expand tokens starting with $ as env variables and interpolates them to empty string.
The other issue was that pipeline previews were working just fine.
If the preview had surfaced this error, the user wouldn't have had to find out after saving and deploying the pipeline.
This PR includes the following changes
$
by replacing it with$$
in that logic.Related Issues / PR's
Fixes #4180