Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Log Detail View: Support for dots in log attributes #4252

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Dec 19, 2023

Summary

The log detail view doesn't display fields containing dot in their name correctly.
It is also not possible to filter by such fields from the log detail view.

Related Issues / PR's

Fixes #3681

Screenshots

Display of fields containing dot in name
Before:
Screenshot from 2023-12-19 10-35-31

After:
Screenshot from 2023-12-19 10-32-30

Filtering by field containing dot by clicking on field name
Before:
dot-support-in-click-to-filter-log-details-before

After:
dot-support-in-click-to-filter-log-details-after

Filtering by field containing dot in name from action menu
Before:
dot-support-in-filter-from-log-details-before

After:
dot-support-in-filter-from-log-details-after

Affected Areas and Manually Tested Areas

Log detail view. Tested manually

@raj-k-singh raj-k-singh changed the title Fe: Log Detail View: Support for dots in log attributes FE: Log Detail View: Support for dots in log attributes Dec 19, 2023
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Displaying and filter in/out is fine, but when you click on the key in detail page then it is not correct in the filter.

@raj-k-singh raj-k-singh marked this pull request as ready for review December 20, 2023 05:31
@YounixM YounixM force-pushed the fe/support-for-dots-in-log-attribs branch from 90d88fa to 8fa5b1b Compare December 21, 2023 07:41
@YounixM YounixM merged commit 43d5ee9 into develop Dec 21, 2023
11 checks passed
@nityanandagohain nityanandagohain deleted the fe/support-for-dots-in-log-attribs branch December 21, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOGS: [FE] Dot support in frontend
3 participants