fix: ignore timestamp from the subquery result for value panel #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
ankitnayan
approved these changes
Dec 27, 2023
|
Irrelevant to the PR:
|
We need at least one column for the join key for a valid ClickHouse query and we use this ts as that key. If we move the formula expression logic outside of ClickHouse then there is no need to have |
|
The way we evaluate the value type panel can be improved a lot. It's also not cache friendly. I think that cleanup deserves its own issue and separate PR. Hence merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently use the timestamp from the subquery for the reduced value of select aggregation (last, sum, min, max). This works fine for single query and formulas if all the queries involved in the expression have data for the same time range. For certain cases the most recent data may not exist for all queries involved in formula expression. And join clause on different timestamps returns No Data https://signoz-team.slack.com/archives/C05AXQL92BT/p1703672801446009.
This change fixes the issue by using
now()as the common timestamp. The value of timestamp in the value type panel is irrelevant so this doesn't make any difference to correctness.