Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend,serviceMap): dynamically truncate service map node label #4365

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix(frontend,serviceMap): dynamically truncate service map node label #4365

merged 2 commits into from
Jan 24, 2024

Conversation

prashanth-nani
Copy link
Contributor

Summary

  • Adjust the node name length dynamically in the service map based on the canvas zoom level.
  • Enable displaying the complete node name without any truncation when hovering over a node in the service map. This feature proves beneficial when viewing all nodes on a zoomed-out canvas while needing quick access to full names, displayed in the tooltip.

Related Issues / PR's

Fixes #1666
Fixes #4318 (Partial)

Screenshots

Default view
Default View

Slight zoom in
Zoomed In

Further zoom in
More Zoomed In

Node hover display
Hover Display

Affected Areas and Manually Tested Areas

  • Servicemap module

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2024

CLA assistant check
All committers have signed the CLA.

@prashanth-nani
Copy link
Contributor Author

@YounixM Please review and provide your feedback

@YounixM
Copy link
Collaborator

YounixM commented Jan 23, 2024

PR solves the issue of handling lengthy service names. ✅

We need to improve the experience of handling min / max zoom, and hover. We can take it up later.

Thanks for the contribution @prashanth-nani .

Approved ✅

YounixM
YounixM previously approved these changes Jan 23, 2024
vikrantgupta25
vikrantgupta25 previously approved these changes Jan 23, 2024
@kunalsingthakur
Copy link

when we are getting this feature merged into master

@YounixM YounixM merged commit fce7ab7 into SigNoz:develop Jan 24, 2024
11 checks passed
Copy link

welcome bot commented Jan 24, 2024

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

@thatsk
Copy link

thatsk commented Feb 20, 2024

When we are releasing this as stable version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants