feat: all line series with same labels should have same color in a da…

[YounixM]

…shboard

Summary by CodeRabbit

• New Features

  • Enhanced chart data retrieval efficiency and readability.
  • Introduced dynamic color generation for charts based on labels.

• Refactor

  • Improved color assignment logic in chart series to utilize a new color generation strategy.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[coderabbitai]

Walkthrough

The updates focus on enhancing the color management for charts by introducing a dynamic color generation method. This approach utilizes labels to determine colors, streamlining the process and improving the visual consistency across charts. The modifications span across the chart data retrieval and tooltip enhancements, including the integration of a new utility for color generation based on specific keys and a predefined color map.

Changes

File Path	Change Summary
.../src/lib/getChartData.ts	Modified to use label directly from allLabels array for improved efficiency and readability.
.../plugins/tooltipPlugin.ts	Added generateColor import; replaced colors array with dynamic colors based on label.
.../utils/generateColor.ts	New file for generating colors based on key and color map.
.../utils/getSeriesData.ts	Added themeColors import; replaced colors import with generateColor function for color assignment based on series label.

🐇✨
In the land of code and hue,
A rabbit worked, to bring something new.
With colors bright and logic tight,
Charts now dance in the perfect light.
🌈🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 64307f3 and 24e1334.

Files selected for processing (4)

• frontend/src/lib/getChartData.ts (1 hunks)
• frontend/src/lib/uPlotLib/plugins/tooltipPlugin.ts (2 hunks)
• frontend/src/lib/uPlotLib/utils/generateColor.ts (1 hunks)
• frontend/src/lib/uPlotLib/utils/getSeriesData.ts (3 hunks)

Additional comments: 4

frontend/src/lib/uPlotLib/utils/getSeriesData.ts (2)

• 1-6: The import of themeColors and generateColor is correctly implemented, aligning with the PR objectives to dynamically generate colors based on series labels. Ensure that themeColors.chartcolors is correctly defined and contains a valid color mapping.
• 48-48: Using generateColor to dynamically assign colors based on the label is a significant improvement for consistency across dashboards. Ensure that themeColors.chartcolors is adequately populated and that the color generation logic in generateColor.ts is robust to handle all expected labels.

frontend/src/lib/uPlotLib/plugins/tooltipPlugin.ts (2)

• 9-9: The addition of the generateColor function from ../utils/generateColor is correctly implemented, aligning with the PR's goal to ensure color consistency across tooltips. This change effectively replaces the static color array with a dynamic approach.
• 58-59: Correctly replacing the static colors array with dynamically generated colors based on labels significantly enhances the consistency and user experience of the dashboard. Ensure that themeColors.chartcolors provides a comprehensive color palette to cover all potential labels.