Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't throw error while fetching orgname #4496

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Feb 5, 2024

if there are no rows it doesn't throw an error but since the err variable was initialized in the same block again with orgNames it caused the error. Have fixed and updated the description.

Summary by CodeRabbit

  • Refactor
    • Simplified the logic for retrieving organization names in the usage upload process, enhancing efficiency by reducing error handling complexity.

Copy link

coderabbitai bot commented Feb 5, 2024

Walkthrough

The recent update simplifies the logic within the UploadUsage method of the Manager struct, specifically regarding how the organization name is retrieved. By choosing to bypass explicit error handling when the organization name is not set, the modification streamlines the process, reducing the complexity previously introduced by handling errors in this context.

Changes

File(s) Summary
ee/query-service/usage/manager.go Simplified organization name retrieval in UploadUsage method by ignoring errors when not set.

Poem

🐇💻
In the realm of code, a rabbit hopped,
Simplifying logic, error checks dropped.
With each leap, the code became neat,
"Let's celebrate," it squeaked, "our task is complete!"
🎉🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

github-actions bot commented Feb 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9d68969 and cf3b7e2.
Files selected for processing (1)
  • ee/query-service/usage/manager.go (1 hunks)

ee/query-service/usage/manager.go Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cf3b7e2 and b9b650b.
Files selected for processing (1)
  • ee/query-service/usage/manager.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • ee/query-service/usage/manager.go

Copy link

github-actions bot commented Feb 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Feb 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain merged commit 554c433 into develop Feb 5, 2024
11 of 13 checks passed
@nityanandagohain nityanandagohain deleted the hotfix/usage-orgname branch February 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants