-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: old and new dashboards in sync with local storage #4520
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
WalkthroughThe updates focus on enhancing dashboard variable management across the frontend. A key addition is the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (4)
- frontend/src/container/NewDashboard/DashboardSettings/Variables/index.tsx (2 hunks)
- frontend/src/container/NewDashboard/DashboardVariablesSelection/DashboardVariableSelection.tsx (2 hunks)
- frontend/src/providers/Dashboard/Dashboard.tsx (3 hunks)
- frontend/src/providers/Dashboard/types.ts (1 hunks)
Additional comments: 4
frontend/src/providers/Dashboard/types.ts (1)
- 22-22: LGTM!
frontend/src/container/NewDashboard/DashboardVariablesSelection/DashboardVariableSelection.tsx (1)
- 76-76: Changing the argument from
id
toname
improves clarity and maintainability.frontend/src/providers/Dashboard/Dashboard.tsx (1)
- 55-55: Adding a default implementation for
transformDashboardVariables
is a good practice.frontend/src/container/NewDashboard/DashboardSettings/Variables/index.tsx (1)
- 80-84: Integrating
transformDashboardVariables
into the dashboard variable update flow enhances consistency and reliability.Also applies to: 173-175
frontend/src/container/NewDashboard/DashboardVariablesSelection/DashboardVariableSelection.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- frontend/src/providers/Dashboard/Dashboard.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- frontend/src/providers/Dashboard/Dashboard.tsx
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
9d8b6af
to
7a192e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- frontend/src/container/NewDashboard/DashboardVariablesSelection/DashboardVariableSelection.tsx (1 hunks)
- frontend/src/providers/Dashboard/Dashboard.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- frontend/src/container/NewDashboard/DashboardVariablesSelection/DashboardVariableSelection.tsx
- frontend/src/providers/Dashboard/Dashboard.tsx
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
name
instead ofid
as the older dashboard variables do not have ID in their response and since we are not updating the dashboard now for variable values the randomly generated ID doesn't work.Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Summary by CodeRabbit
Summary of changes