[Fix]: delete formula issue

[Rajat-Dabade]

Summary by CodeRabbit

• New Features

  • Introduced a delete button in the Query Builder, enhancing user control over query management.

• Refactor

  • Optimized the logic for displaying the delete button in the Query Builder, improving performance and maintainability.

[coderabbitai]

Walkthrough

The overall change involves refining the logic and presentation of the delete button within a QueryBuilder component. Previously, the decision to display the delete button was made internally in several components based on the query data length. Now, this logic has been centralized and streamlined, with the showDeleteButton decision being passed as a prop to the relevant components, enhancing modularity and making the components more flexible and easier to maintain.

Changes

File Path	Change Summary
.../Formula/Formula.tsx	Added showDeleteButton prop to enable the display of a delete button.
.../QBEntityOptions/QBEntityOptions.tsx	Removed useQueryBuilder import; showDeleteButton logic is now passed as a prop.
.../Query/Query.tsx	Added currentQuery variable; condition to show delete button based on currentQuery.builder.queryData length.

🐰✨
In the realm of code, where queries build and flow,
A little change was made, to let control show.
"Show or hide," now a choice so bright,
With props passed down, in the moonlight's sight.
🌟🌙

• CodeRabbit 🐇💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3a20862 and e56faa7.

Files selected for processing (3)

• frontend/src/container/QueryBuilder/components/Formula/Formula.tsx (1 hunks)
• frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.tsx (3 hunks)
• frontend/src/container/QueryBuilder/components/Query/Query.tsx (2 hunks)

Additional comments: 2

frontend/src/container/QueryBuilder/components/QBEntityOptions/QBEntityOptions.tsx (1)

• 24-24: The implementation of showDeleteButton for conditional rendering of the delete button is correct and follows best practices for prop-driven component design.

frontend/src/container/QueryBuilder/components/Query/Query.tsx (1)

• 291-291: The conditional logic for showing the delete button based on currentQuery.builder.queryData.length > 1 is appropriate. This ensures the delete button is only shown when there are multiple query data entries, enhancing the user experience by preventing accidental deletions.