Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shortcuts break when there are multiple queries #4532

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Feb 12, 2024

Summary

  • Remove the shortcut from search bar of QB as it causes issues with multiple search bars being present

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

Summary by CodeRabbit

  • New Features
    • Improved the QueryBuilderSearch component to dynamically register a shortcut for focusing the search bar based on the presence of multiple queries.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Feb 12, 2024
Copy link

coderabbitai bot commented Feb 12, 2024

Warning

Rate Limit Exceeded

@Vikrant2520 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 39 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between c5bf95c and d3d824a.

Walkthrough

The update to the QueryBuilderSearch component enhances user interaction by dynamically registering a shortcut for focusing the search bar based on the presence of multiple queries. This is achieved through the useQueryBuilder hook, which now provides currentQuery to assess the query count.

Changes

File Path Change Summary
.../QueryBuilder/filters/QueryBuilderSearch/index.tsx Updated to register a focus shortcut for the search bar only when multiple queries are present.

🐰 A little change, oh so bright,
Making search just feel so right.
When queries abound, far and near,
A shortcut appears, bringing cheer.
🌟 For every coder, big and small,
This rabbit's update, aids them all.
Hop, hop, hooray, for progress clear!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6bc5cea and c5bf95c.
Files selected for processing (1)
  • frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx (2 hunks)
Additional comments: 1
frontend/src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx (1)
  • 82-82: The useQueryBuilder hook is used correctly to obtain currentQuery. Ensure that currentQuery is always updated to reflect the current state accurately.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit 02f83e4 into develop Feb 12, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the fix-multiple-queries branch February 12, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants