Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zoom in for bar chart logs explorer #4542

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Feb 14, 2024

Summary

  • Added bar chart zoom in for logs bar chart with back navigation support

Related Issues / PR's

Screenshots

Screen.Recording.2024-02-14.at.2.27.09.PM.mov

Affected Areas and Manually Tested Areas

Summary by CodeRabbit

  • New Features
    • Enhanced the Logs Explorer Chart with new interactive capabilities:
      • Users can now select specific areas on the graph via drag select.
      • Improved back navigation handling for a smoother user experience.
    • Added automatic updates to the chart based on URL query parameters for more dynamic data visualization.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Feb 14, 2024
Copy link

coderabbitai bot commented Feb 14, 2024

Walkthrough

The update to the LogsExplorerChart component in the frontend enhances user interaction and navigation. It introduces functionality for handling drag selections within the chart and managing back navigation efficiently. The addition of several imports supports these new features and the integration of URL query parameters for state management. The modifications ensure a smoother user experience by dynamically updating the chart and maintaining state consistency during navigation events.

Changes

File Path Change Summary
.../LogsExplorerChart/index.tsx Added imports, initialized dispatch, urlQuery, location, added onDragSelect, handleBackNavigation, modified Graph component, added useEffect for popstate event handling.

🐇✨
In the land of code and light,
A rabbit hopped, both day and night.
To enhance the chart, it leaped with grace,
Drag select, back navigate, a swift embrace.
With every line, the story grew,
A tale of updates, fresh and true.
🌟📉📈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c75a44c and 6cf23d0.
Files selected for processing (1)
  • frontend/src/container/LogsExplorerChart/index.tsx (4 hunks)
Additional comments: 4
frontend/src/container/LogsExplorerChart/index.tsx (4)
  • 3-14: Ensure all new imports are used within the file to avoid unnecessary overhead and maintain clean code.
  • 25-27: Initialization of dispatch, urlQuery, and location is correctly done using respective hooks.
  • 79-86: The useEffect hook for adding and removing the popstate event listener is correctly implemented. However, the dependency array is empty, which is fine in this context as handleBackNavigation does not depend on any props or state. Ensure this remains valid if the component's logic evolves.
  • 106-112: Modification to the Graph component to include the onDragSelect prop is correctly implemented, enabling the zoom-in functionality. Ensure that the Graph component's propTypes (or TypeScript types if applicable) are updated to reflect this new prop.

@vikrantgupta25 vikrantgupta25 force-pushed the bar-chart-zoomin branch 2 times, most recently from d70076b to dbe6bd4 Compare February 14, 2024 07:47
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cfea51d and dbe6bd4.
Files selected for processing (1)
  • frontend/src/container/LogsExplorerChart/index.tsx (4 hunks)
Additional comments: 4
frontend/src/container/LogsExplorerChart/index.tsx (4)
  • 3-14: Imports are correctly added for the new functionality. Ensure all imported modules are used within the file to avoid unnecessary imports.
  • 25-27: Initialization of dispatch, urlQuery, and location is correctly done. These are essential for the feature's functionality.
  • 79-86: The useEffect hook for adding and removing the popstate event listener is correctly implemented. However, the dependency array is empty, which is appropriate in this context since handleBackNavigation does not depend on any props or state that changes over time.
  • 106-112: Modification to the Graph component to include the onDragSelect prop is correctly implemented, enabling the new zoom-in functionality. Ensure the Graph component is updated to handle this prop appropriately.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e0df371 and d7d8416.
Files selected for processing (1)
  • frontend/src/container/LogsExplorerChart/index.tsx (4 hunks)
Additional comments: 4
frontend/src/container/LogsExplorerChart/index.tsx (4)
  • 3-14: Imports for QueryParams, useUrlQuery, GetMinMax, getTimeString, history, useLocation, UpdateTimeInterval, dispatch, useEffect are correctly added to support the new zoom-in functionality. Ensure these imports are used efficiently and any unused imports are removed to keep the code clean.
  • 25-27: Initialization of dispatch, urlQuery, and location is correctly done. These are essential for handling state management and URL manipulation for the zoom-in feature.
  • 79-86: The useEffect hook for handling the popstate event is correctly set up to manage back navigation. This ensures that the zoom-in feature integrates well with browser navigation. The cleanup function to remove the event listener is correctly implemented, ensuring no memory leaks.
  • 106-112: Modification to the Graph component to include the onDragSelect prop is correctly implemented. This change is crucial for enabling the drag select functionality for zooming in on the chart. Ensure that the Graph component is updated to handle this prop appropriately.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit 8124117 into develop Feb 14, 2024
11 of 12 checks passed
@YounixM YounixM deleted the bar-chart-zoomin branch February 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants