fix: redirect old logs routes to new routes #4584
Conversation
WalkthroughThe update introduces a more efficient handling of route redirection for outdated paths and integrates a new private route for pipeline logs. It streamlines the access to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- frontend/src/AppRoutes/Private.tsx (3 hunks)
- frontend/src/AppRoutes/routes.ts (3 hunks)
Additional comments: 6
frontend/src/AppRoutes/Private.tsx (3)
- 31-32: Refactoring to directly destructure
pathnamefromuseLocation()is a clean and efficient way to access the current route. This change improves readability and reduces the amount of code.- 67-67: The introduction of the
isOldRoutecheck is a crucial part of the redirection logic. It efficiently determines if the current route is outdated by checking its presence in theoldRoutesarray. This approach is straightforward and effective for the intended purpose.- 168-175: The redirection logic for old routes using
oldNewRoutesMappingis well-implemented. By creating a new location object with the updatedpathnameand usinghistory.replace, the application ensures a seamless transition for the user without adding history entries. This approach maintains the user's navigation history clean and focused.frontend/src/AppRoutes/routes.ts (3)
- 282-288: Adding the new route for
ROUTES.LOGS_PIPELINESwith thePipelinePagecomponent and marking it as private (isPrivate: true) is a positive change. It expands the application's functionality and ensures that access is appropriately restricted to authorized users.- 356-361: The introduction of the
oldRoutesconstant is a good practice for managing outdated routes in a centralized manner. This list makes it easier to identify and handle old routes that need redirection, contributing to cleaner and more maintainable code.- 363-368: The
oldNewRoutesMappingprovides a clear and direct mapping between old routes and their new counterparts. This structure is essential for implementing the redirection logic efficiently and ensures that users are seamlessly navigated to the correct new routes. The mapping is well-defined and covers the necessary routes.
YounixM
force-pushed
the
redirect-old-logs-explorer-routes-to-new-routes
branch
from
c6ab9ac
to
cd1b0c7
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- frontend/src/AppRoutes/Private.tsx (3 hunks)
- frontend/src/AppRoutes/routes.ts (3 hunks)
Files skipped from review as they are similar to previous changes (2)
- frontend/src/AppRoutes/Private.tsx
- frontend/src/AppRoutes/routes.ts
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
redirect old logs routes to new routes
Summary by CodeRabbit