fix: date time value initialising to start of day in case of typing

[vikrantgupta25]

Summary

• Added lexical context inside the custom date time handler to handle typing and calendar select dates separately

Related Issues / PR's

Screenshots

Screen.Recording.2024-02-22.at.2.46.38.PM.mov

Affected Areas and Manually Tested Areas

Summary by CodeRabbit

• New Features
  • Enhanced the date and time selection feature to adjust start and end times based on user context, improving usability and precision in time selection.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[coderabbitai]

Walkthrough

The recent update introduces a new parameter, lexicalContext, to enhance the functionality of the custom date handler across the application. This addition allows the system to differentiate contexts, specifically between a custom date picker and a custom date-time input. The handling logic adjusts start and end times based on the identified context, ensuring accurate time intervals are set and stored, thereby improving the user's date and time selection experience.

Changes

File Path	Change Summary
.../CustomTimePicker/CustomTimePickerPopoverContent.tsx	Added lexicalContext parameter to onCustomDateHandler.
.../DateTimeSelectionV2/config.ts	Introduced LexicalContext enum with CUSTOM_DATE_PICKER and CUSTOM_DATE_TIME_INPUT values.
.../DateTimeSelectionV2/index.tsx	Imported LexicalContext, updated onCustomDateHandler to adjust times based on context, and refined setting/updating of time intervals.

🐇✨
In the realm of code, where time's a maze,
A rabbit hopped, setting dates ablaze.
With context in paw, it leapt through the night,
Ensuring your moments are captured just right.
So cheer, for the times are now wisely picked,
By a rabbit's touch, the clock's magic tricked.
🎩🕰️

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 7bca847 and 7492a4f.

Files selected for processing (3)

• frontend/src/components/CustomTimePicker/CustomTimePickerPopoverContent.tsx (3 hunks)
• frontend/src/container/TopNav/DateTimeSelectionV2/config.ts (1 hunks)
• frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx (2 hunks)

Additional comments: 4

frontend/src/components/CustomTimePicker/CustomTimePickerPopoverContent.tsx (2)

• 24-26: The addition of the lexicalContext parameter to the onCustomDateHandler function is a significant improvement. It allows for more nuanced handling of date inputs based on the user's interaction method. This change aligns well with the PR's objectives and enhances the application's usability by providing context-sensitive processing of date and time selections.
• 70-70: The usage of LexicalContext.CUSTOM_DATE_PICKER in the onModalOkHandler function is correct and demonstrates the intended differentiation between manual typing and calendar selection. This ensures that the application can initialize date and time values appropriately based on the input method, improving the overall user experience.

frontend/src/container/TopNav/DateTimeSelectionV2/config.ts (1)

• 152-154: The introduction of the LexicalContext enumeration is a well-thought-out addition. It provides clear, semantic values (CUSTOM_DATE_PICKER and CUSTOM_DATE_TIME_INPUT) that facilitate the differentiation of user input methods. This enumeration will be instrumental in implementing context-aware logic throughout the application.

frontend/src/container/TopNav/DateTimeSelectionV2/index.tsx (1)

• 322-345: The implementation of LexicalContext handling in the onCustomDateHandler function is well-executed. By adjusting startTime and endTime based on the context (CUSTOM_DATE_PICKER), the application can now handle date and time values more accurately. This logic ensures that when a date is selected via the custom date picker, the time is set to the start or end of the day, which aligns with the PR's objectives to improve user experience through context-sensitive processing. Great job on this enhancement!