Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: updated routes and modal for create alert css #4602

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

Rajat-Dabade
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade commented Feb 26, 2024

Before:

Screenshot 2024-02-27 at 2 36 49 AM

After:

Dark mode:

Screenshot 2024-02-27 at 2 43 36 AM

Light mode:
Screenshot 2024-02-27 at 2 42 01 AM

Summary by CodeRabbit

  • New Features
    • Updated application routing to reflect a more organized structure for logs and traces views.
    • Introduced a new styling for the create alert modal, including support for a light mode.

Copy link

coderabbitai bot commented Feb 26, 2024

Walkthrough

The recent updates focus on enhancing the application's routing and user interface. Specifically, the routing for saving views has been restructured under /logs and /traces for a more organized approach. Additionally, a new style file has been introduced to beautify the create alert modal in light mode, alongside modifications in the FormAlertRules component to integrate these styles, improving the user experience for alert creation.

Changes

Files Change Summary
frontend/src/constants/routes.ts Updated routes for logs and traces, adopting a nested structure.
frontend/src/container/FormAlertRules/... Introduced new styles for the create alert modal and updated component styling.

🐰✨
In a land of code and UI,
Where routes like rivers flow,
A rabbit hopped, with a gleeful sigh,
To nest paths where logs and traces grow.
🎨 With colors bright and modal light,
It dressed alerts in style so right.
🌟🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c38247a and 0f2f452.
Files ignored due to path filters (1)
  • frontend/public/locales/en/titles.json is excluded by: !**/*.json
Files selected for processing (3)
  • frontend/src/constants/routes.ts (1 hunks)
  • frontend/src/container/FormAlertRules/FormAlertRules.styles.scss (1 hunks)
  • frontend/src/container/FormAlertRules/index.tsx (2 hunks)
Additional comments: 5
frontend/src/container/FormAlertRules/FormAlertRules.styles.scss (2)
  • 1-14: The styling for the .create-alert-modal in dark mode looks well-structured and uses CSS custom properties for theme consistency. Ensure that these variables (--bg-ink-400 and --bg-vanilla-100) are defined in a global stylesheet and accurately reflect the intended colors for dark mode.
  • 16-29: The styling for the .create-alert-modal in light mode is consistent with the dark mode structure, using appropriate CSS custom properties. As with the dark mode, verify that the variables (--bg-vanilla-100 and --bg-ink-500) are defined globally and represent the correct colors for light mode.
frontend/src/constants/routes.ts (1)
  • 45-46: The addition of nested routes for saved views under /logs and /traces is a positive change for organizing the application's routing structure. Ensure there are no conflicts with existing routes and that these new routes are integrated into the application's navigation and permission checks appropriately.
frontend/src/container/FormAlertRules/index.tsx (2)
  • 1-1: The import of FormAlertRules.styles.scss is correctly implemented, ensuring the new styles are applied to the FormAlertRules component. This aligns with the PR objectives of updating the styling for the create alert modal.
  • 366-366: The addition of the className prop with the value 'create-alert-modal' to the Modal.confirm call is correctly implemented. This ensures that the modal uses the specific styles defined in the imported stylesheet, aligning with the PR's objective of enhancing the modal's visual appeal.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0f2f452 and 33b80af.
Files selected for processing (1)
  • frontend/src/container/FormAlertRules/FormAlertRules.styles.scss (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • frontend/src/container/FormAlertRules/FormAlertRules.styles.scss

vikrantgupta25
vikrantgupta25 previously approved these changes Mar 4, 2024
Copy link
Collaborator

@YounixM YounixM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add old - new route mapping to handle auto redirects for saved / old routes

frontend/src/constants/routes.ts Show resolved Hide resolved
frontend/src/constants/routes.ts Show resolved Hide resolved
@Rajat-Dabade Rajat-Dabade merged commit 90d7f02 into develop Mar 4, 2024
11 checks passed
@Rajat-Dabade Rajat-Dabade deleted the alert-save-view-refurb branch March 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants