-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: updated routes and modal for create alert css #4602
Conversation
WalkthroughThe recent updates focus on enhancing the application's routing and user interface. Specifically, the routing for saving views has been restructured under Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
frontend/public/locales/en/titles.json
is excluded by:!**/*.json
Files selected for processing (3)
- frontend/src/constants/routes.ts (1 hunks)
- frontend/src/container/FormAlertRules/FormAlertRules.styles.scss (1 hunks)
- frontend/src/container/FormAlertRules/index.tsx (2 hunks)
Additional comments: 5
frontend/src/container/FormAlertRules/FormAlertRules.styles.scss (2)
- 1-14: The styling for the
.create-alert-modal
in dark mode looks well-structured and uses CSS custom properties for theme consistency. Ensure that these variables (--bg-ink-400
and--bg-vanilla-100
) are defined in a global stylesheet and accurately reflect the intended colors for dark mode.- 16-29: The styling for the
.create-alert-modal
in light mode is consistent with the dark mode structure, using appropriate CSS custom properties. As with the dark mode, verify that the variables (--bg-vanilla-100
and--bg-ink-500
) are defined globally and represent the correct colors for light mode.frontend/src/constants/routes.ts (1)
- 45-46: The addition of nested routes for saved views under
/logs
and/traces
is a positive change for organizing the application's routing structure. Ensure there are no conflicts with existing routes and that these new routes are integrated into the application's navigation and permission checks appropriately.frontend/src/container/FormAlertRules/index.tsx (2)
- 1-1: The import of
FormAlertRules.styles.scss
is correctly implemented, ensuring the new styles are applied to theFormAlertRules
component. This aligns with the PR objectives of updating the styling for the create alert modal.- 366-366: The addition of the
className
prop with the value'create-alert-modal'
to theModal.confirm
call is correctly implemented. This ensures that the modal uses the specific styles defined in the imported stylesheet, aligning with the PR's objective of enhancing the modal's visual appeal.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- frontend/src/container/FormAlertRules/FormAlertRules.styles.scss (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- frontend/src/container/FormAlertRules/FormAlertRules.styles.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add old - new route mapping to handle auto redirects for saved / old routes
Before:
After:
Dark mode:
Light mode:
Summary by CodeRabbit