Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(telemetry): include environment variables for ee build #4603

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Feb 27, 2024

Summary

This PR include additional environment variables to enable frontend telemetry.

Need to set the following GitHub secrets:

  • SENTRY_AUTH_TOKEN
  • SENTRY_ORG
  • SENTRY_PROJECT_ID
  • SENTRY_DSN
  • TUNNEL_URL
  • TUNNEL_DOMAIN

Related Issues / PR's

Depends on #4560

Screenshots

NA

Affected Areas and Manually Tested Areas

NA

Signed-off-by: Prashant Shahi prashant@signoz.io

Summary by CodeRabbit

  • Chores
    • Updated environment settings for improved error tracking and secure tunneling in the frontend.

Signed-off-by: Prashant Shahi <prashant@signoz.io>
Copy link

coderabbitai bot commented Feb 27, 2024

Walkthrough

This update introduces environment variables crucial for Sentry and tunnel configuration into the frontend's environment settings. It signifies an enhancement in error tracking and secure connectivity for the application, aiming to bolster both its reliability and performance.

Changes

File Path Change Summary
.github/workflows/push.yaml Added Sentry and tunnel configuration environment variables to the frontend environment file.

🐇✨
In the realm of code, where rabbits dwell,
A change was made, a tale to tell.
Sentry's watch, tunnels so deep,
In the environment's keep.
🌟🚀
Through the digital burrow, we hop with glee,
For better connections and error-free spree.
🐾💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c38247a and fa07e41.
Files selected for processing (1)
  • .github/workflows/push.yaml (1 hunks)
Additional comments: 1
.github/workflows/push.yaml (1)
  • 155-160: The addition of Sentry and tunnel-related environment variables (SENTRY_AUTH_TOKEN, SENTRY_ORG, SENTRY_PROJECT_ID, SENTRY_DSN, TUNNEL_URL, TUNNEL_DOMAIN) to the .env file for the frontend is a significant enhancement for telemetry capabilities. However, ensure that these secrets are properly set up in the GitHub repository settings to avoid build failures. Additionally, consider documenting these new environment variables in the project's README or in the relevant documentation section to inform other developers and maintain transparency about the telemetry capabilities and requirements.

@YounixM YounixM merged commit d9ab100 into develop Feb 27, 2024
11 checks passed
@YounixM YounixM deleted the ci/telemetry-env branch February 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants