-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(telemetry): include environment variables for ee build #4603
Conversation
Signed-off-by: Prashant Shahi <prashant@signoz.io>
WalkthroughThis update introduces environment variables crucial for Sentry and tunnel configuration into the frontend's environment settings. It signifies an enhancement in error tracking and secure connectivity for the application, aiming to bolster both its reliability and performance. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/push.yaml (1 hunks)
Additional comments: 1
.github/workflows/push.yaml (1)
- 155-160: The addition of Sentry and tunnel-related environment variables (
SENTRY_AUTH_TOKEN
,SENTRY_ORG
,SENTRY_PROJECT_ID
,SENTRY_DSN
,TUNNEL_URL
,TUNNEL_DOMAIN
) to the.env
file for the frontend is a significant enhancement for telemetry capabilities. However, ensure that these secrets are properly set up in the GitHub repository settings to avoid build failures. Additionally, consider documenting these new environment variables in the project's README or in the relevant documentation section to inform other developers and maintain transparency about the telemetry capabilities and requirements.
Summary
This PR include additional environment variables to enable frontend telemetry.
Need to set the following GitHub secrets:
SENTRY_AUTH_TOKEN
SENTRY_ORG
SENTRY_PROJECT_ID
SENTRY_DSN
TUNNEL_URL
TUNNEL_DOMAIN
Related Issues / PR's
Depends on #4560
Screenshots
NA
Affected Areas and Manually Tested Areas
NA
Signed-off-by: Prashant Shahi prashant@signoz.io
Summary by CodeRabbit