Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): graph legends is fixed #461

Merged
merged 6 commits into from
Dec 10, 2021
Merged

fix(UI): graph legends is fixed #461

merged 6 commits into from
Dec 10, 2021

Conversation

palashgdev
Copy link
Contributor

In This Pr #367 is fixed

@palashgdev palashgdev added bug Something isn't working frontend labels Dec 6, 2021
@palashgdev palashgdev self-assigned this Dec 6, 2021
@palashgdev palashgdev marked this pull request as ready for review December 6, 2021 14:52
@pranay01 pranay01 self-requested a review December 9, 2021 08:09
@pranay01
Copy link
Collaborator

pranay01 commented Dec 9, 2021 •
edited

@pal-sig Seeing this scroll bar in chrome which looks quite bad. Is there a way to make it look better.
Image 09-12-2021 at 13 42

Chrome version - Version 96.0.4664.55 (Official Build) (arm64)

@pranay01
Copy link
Collaborator

pranay01 commented Dec 9, 2021 •
edited

@pal-sig Even in application metrics. dashboard the scroll is coming - both in chrome and firefox

https://share.getcloudapp.com/qGuR2kbQ

Image 09-12-2021 at 13 51

@pranay01
Copy link
Collaborator

pranay01 commented Dec 9, 2021 •
edited

@pal-sig Why application latency chart shows only a single point but RPS chart shows correctly based on duration selected according to date time selector? Happening in both firefox and chrome
Image 09-12-2021 at 13 54

@palashgdev
Copy link
Contributor Author

@pal-sig Why application latency chart shows only a single point but RPS chart shows correctly based on duration selected according to date time selector? Happening in both firefox and chrome Image 09-12-2021 at 13 54

Can you please confirm the data receive from network ?

@palashgdev
Copy link
Contributor Author

@pal-sig Even in application metrics. dashboard the scroll is coming - both in chrome and firefox

https://share.getcloudapp.com/qGuR2kbQ

Image 09-12-2021 at 13 51

will hide the scroll

@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pranay01
Copy link
Collaborator

@pal-sig Ok - the single point issue seems more like a backend issue

@ankitnayan ankitnayan merged commit c792237 into SigNoz:main Dec 10, 2021
@pranay01 pranay01 mentioned this pull request Dec 12, 2021
Closed
@pranay01
Copy link
Collaborator

pranay01 commented Dec 12, 2021 •
edited

fixes #367 #437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

@pranay01 pranay01 Awaiting requested review from pranay01

Assignees

@palashgdev palashgdev

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@palashgdev @pranay01 @ankitnayan