Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: qs integrations http api #4622

Merged
merged 6 commits into from
Mar 2, 2024
Merged

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Feb 29, 2024

Summary

Adds HTTP apis in query service for integrations
See https://www.notion.so/signoz/Integration-V0-UI-Facing-APIs-60c543247c6a432eb9fd69c3376e5602 for details of the expected API contract

Note: This PR doesn't include changes related to integration connection status, which will come as a follow up change. This includes the connection_status field in integration details response and the dedicated API for checking an integration's connection status

Related Issues / PR's

Contributes to #4462

Affected Areas and Manually Tested Areas

Query Service HTTP APIs

@github-actions github-actions bot added the enhancement New feature or request label Feb 29, 2024
@raj-k-singh raj-k-singh changed the title Feat/qs integrations http api Feat: qs integrations http api Feb 29, 2024
@raj-k-singh raj-k-singh force-pushed the feat/qs-integrations-http-api branch 2 times, most recently from 8755f6e to efea24e Compare February 29, 2024 14:16
@raj-k-singh raj-k-singh marked this pull request as ready for review February 29, 2024 14:27
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can address my comment in follow up PR.

pkg/query-service/app/integrations/manager.go Show resolved Hide resolved
@raj-k-singh raj-k-singh merged commit 0870030 into develop Mar 2, 2024
11 checks passed
@raj-k-singh raj-k-singh deleted the feat/qs-integrations-http-api branch March 2, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants