fix: [SIG-542]: handle special characters in servicename #4649

vikrantgupta25 · 2024-03-05T11:27:24Z

we are encoding the service name while adding it to the URL and decoding the service name while getting it back and sending to the API calls.
while this works fine , the presence of the % operator in the service name will cause issues as taken note by the library providers themselves as well.
needed to update the webpack config to support routes with . operator as well.

Screen.Recording.2024-03-06.at.10.34.15.AM.mov

github-actions · 2024-03-05T11:27:37Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions · 2024-03-06T05:07:21Z

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions bot added the bug Something isn't working label Mar 5, 2024

vikrantgupta25 force-pushed the SIG-542 branch from 2a1ab48 to d898f54 Compare March 6, 2024 05:03

vikrantgupta25 marked this pull request as ready for review March 6, 2024 05:04

vikrantgupta25 requested review from srikanthccv and YounixM as code owners March 6, 2024 05:04

vikrantgupta25 added 3 commits March 7, 2024 22:31

fix: [SIG-542]: handle special characters in servicename

be48d18

feat: handle . operator in the URL

d00a47b

chore: left files to update

be5e1cd

vikrantgupta25 force-pushed the SIG-542 branch from 355b87b to be5e1cd Compare March 7, 2024 17:01

srikanthccv approved these changes Mar 7, 2024

View reviewed changes

YounixM approved these changes Mar 7, 2024

View reviewed changes

YounixM merged commit 7051831 into develop Mar 7, 2024
11 checks passed

YounixM deleted the SIG-542 branch March 7, 2024 18:38

Provide feedback