Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SIG-546]: user with viewer roles can only view saved views #4663

Merged
merged 7 commits into from
Mar 11, 2024
Merged

feat: [SIG-546]: user with viewer roles can only view saved views #4663

merged 7 commits into from
Mar 11, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 7, 2024 •
edited

Summary

  • User with viewer role should only be allowed to view the saved views
  • User with admin / editor / author role can edit / delete / update all views
  • Hide the dashboard create button for the viewer roles

Related Issues / PR's

#4645

Screenshots

image
Screen.Recording.2024-03-07.at.10.19.57.PM.mov

Affected Areas and Manually Tested Areas

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Mar 7, 2024
@vikrantgupta25 vikrantgupta25 changed the title feat: [SIG-543]: Users with VIEWER access can create/edit/delete view… feat: [SIG-543]: user with viewer roles can only edit create and delete their views Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 changed the title feat: [SIG-543]: user with viewer roles can only edit create and delete their views feat: [SIG-546]: user with viewer roles can only edit create and delete their views Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 changed the title feat: [SIG-546]: user with viewer roles can only edit create and delete their views feat: [SIG-546]: user with viewer roles can only view saved views Mar 7, 2024
@vikrantgupta25 vikrantgupta25 merged commit 6b87118 into develop Mar 11, 2024
11 checks passed
@vikrantgupta25 vikrantgupta25 deleted the SIG-546 branch March 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vikrantgupta25 @YounixM @Rajat-Dabade