fix(BUG): Allow webpack to link CSS with bundled HTML file. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While porting the webpack config file from typescript to javascript, commit 3e0f5a8 accidentally removed style-loader from config setting. Due to this, the CSS file wasn't being attached with the bundled html file. Fixed this by adding the style-loader back to config settings in webpack.
|
Kudos, SonarCloud Quality Gate passed!
|
palashgdev
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added background in commit description.
Would be great if @pal-sig can confirm it :)
Screenshot
Screen.Recording.2021-12-07.at.2.45.31.PM.mov
Fixes #454.