Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SIG-571]: added support for has and nhas operator for json filter #4736

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 21, 2024

Summary

  • added support for has and nhas operators when the key ends with [*] and starts with body.

Related Issues / PR's

Fixes #3629

Screenshots

Screen.Recording.2024-03-21.at.7.28.43.PM.mov

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Mar 21, 2024
Rajat-Dabade
Rajat-Dabade previously approved these changes Mar 21, 2024
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • for check add prefix body. as well along with [*] .
  • Once the check is passed, don't suggest other operators other than has and nhas.

This is because has and nhas works with only json full text search as of now.

@vikrantgupta25 vikrantgupta25 merged commit 9e557a0 into develop Mar 22, 2024
11 checks passed
@vikrantgupta25 vikrantgupta25 deleted the SIG-571 branch March 22, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOGS[FE]: JSON filter operator suggestion
4 participants