Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update time range selection flows to handle relative and absolu… #4742

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

YounixM
Copy link
Collaborator

@YounixM YounixM commented Mar 24, 2024

…te times

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YounixM
Screenshot 2024-03-29 at 1 49 13 PM

Screenshot 2024-03-29 at 1 52 39 PM

The share button is not centre-aligned with the other button.

@Rajat-Dabade
Copy link
Contributor

Suggestion (Can be taken up later): It's hard to read the Please select / enter.... in light mode, can we use the darker colour?

Screenshot 2024-03-29 at 2 00 20 PM

@YounixM
Copy link
Collaborator Author

YounixM commented Mar 29, 2024

@Rajat-Dabade: Addressed above comments

@YounixM YounixM merged commit 6eced60 into develop Mar 29, 2024
11 checks passed
@YounixM YounixM deleted the relative-absolute-time branch March 29, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants