Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SIG-573]: Fixed billing page issues #4744

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat: [SIG-573]: Fixed billing page issues #4744

merged 2 commits into from
Mar 27, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Mar 26, 2024

Summary

Fixes -

  • fixed billing page error on API failure
  • Added null handling for billing cycle info alert
  • fixed graph's dependency on the billingStartTime and billingEndTime
  • fixed tooltip text highlight issue
Screen.Recording.2024-03-26.at.9.29.52.AM.mov

Related Issues / PR's

https://linear.app/signoz-io/issue/SIG-573/billing-page-issues

Screenshots

NA

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels Mar 26, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Rajat-Dabade
Rajat-Dabade previously approved these changes Mar 26, 2024
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments, Will save memory usage and time complexity

vikrantgupta25
vikrantgupta25 previously approved these changes Mar 27, 2024
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YounixM YounixM merged commit dbd4363 into develop Mar 27, 2024
11 checks passed
@YounixM YounixM deleted the SIG-573 branch March 27, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants