Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [SIG-575]: no data in new trace explorer page specific scenario #4748

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: [SIG-575]: no data in new trace explorer page specific scenario #4748

merged 2 commits into from
Mar 28, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 26, 2024 •
edited

Summary

  • the retention period for aggregate keys is 48 hours so when we do not get aggregate keys from the API response we get no data in case of traces for a time range longer than 48 hours.
  • so we hardcoded the base aggregate in case of traces when the API call returns no aggregate keys

Related Issues / PR's

Fixes - #3443

Screenshots

Screen.Recording.2024-03-26.at.7.21.37.PM.mov

Affected Areas and Manually Tested Areas

  • New Trace Explorer

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Mar 26, 2024
@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review March 26, 2024 13:46
@YounixM YounixM merged commit 5959963 into develop Mar 28, 2024
11 checks passed
@YounixM YounixM deleted the SIG-575 branch March 28, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@makeavish makeavish makeavish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vikrantgupta25 @YounixM @makeavish