Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log chips not forming making filtering not work #4749

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 26, 2024

Summary

  • The logic to split the parts on the basis of - was missing an edge case where it was not taking the key properly when no - is present in the query

Related Issues / PR's

Screenshots

Screen.Recording.2024-03-27.at.12.49.00.AM.mov

Affected Areas and Manually Tested Areas

different filters in the logs explorer page

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Mar 26, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit e167979 into develop Mar 26, 2024
11 checks passed
@vikrantgupta25 vikrantgupta25 deleted the log-chips branch March 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants