Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: billing page crashes when all three signal data is not present #4764

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 28, 2024

Summary

  • the calculateStartEndTime function expected all the signals to have daywisebreakdown which is not the case.
  • added a null check for the same in case some signal is missing data

Related Issues / PR's

Screenshots

before

Screen.Recording.2024-03-29.at.12.09.02.AM.mov

After

Screen.Recording.2024-03-29.at.12.08.31.AM.mov

Affected Areas and Manually Tested Areas

billing graph usage

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Mar 28, 2024
@vikrantgupta25 vikrantgupta25 changed the title fix: billing graph page crash fix: billing page crashes when all three signal data is not present Mar 28, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review March 28, 2024 18:39
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit e6e377b into develop Mar 29, 2024
10 of 14 checks passed
@vikrantgupta25 vikrantgupta25 deleted the fix-billing-graph branch March 29, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants