Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboarding flow - enable users to submit request for a new data… #4786

Merged
merged 3 commits into from
Apr 1, 2024
Merged

feat: onboarding flow - enable users to submit request for a new data… #4786

merged 3 commits into from
Apr 1, 2024

Conversation

YounixM
Copy link
Collaborator

@YounixM YounixM commented Apr 1, 2024 •
edited

Screenshot 2024-04-01 at 3 31 11 PM Screenshot 2024-04-01 at 3 31 18 PM

@request-info Request Info
Copy link

request-info bot commented Apr 1, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Apr 1, 2024
@YounixM YounixM marked this pull request as ready for review April 1, 2024 10:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Rajat-Dabade
Rajat-Dabade suggested changes Apr 1, 2024
View reviewed changes
frontend/src/utils/app.ts Outdated Show resolved Hide resolved
vikrantgupta25
vikrantgupta25 requested changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove true from isCloudUser

@YounixM
Copy link
Collaborator Author

YounixM commented Apr 1, 2024

Remove true from isCloudUser

Done ✅

Rajat-Dabade
Rajat-Dabade approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vikrantgupta25
vikrantgupta25 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@YounixM YounixM merged commit 1610b95 into develop Apr 1, 2024
11 checks passed
@YounixM YounixM deleted the request-entity-support branch April 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

@makeavish makeavish Awaiting requested review from makeavish

Assignees
No one assigned
Labels
enhancement New feature or request request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YounixM @Rajat-Dabade @vikrantgupta25