Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QB - Logs - Enable TimeShift function #4792

Merged
merged 3 commits into from
Apr 4, 2024
Merged

QB - Logs - Enable TimeShift function #4792

merged 3 commits into from
Apr 4, 2024

Conversation

YounixM
Copy link
Collaborator

@YounixM YounixM commented Apr 2, 2024

Screenshot 2024-04-02 at 1 45 17 PM Screenshot 2024-04-02 at 1 47 19 PM

nityanandagohain
nityanandagohain requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • it is using the /api/v4/query_range, it should use /api/v3/query_range for logs queries.
  • in the old dashboards functions options is not showing up

nityanandagohain
nityanandagohain approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rajat-Dabade
Rajat-Dabade approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YounixM YounixM merged commit 6a4aa9a into develop Apr 4, 2024
11 checks passed
@YounixM YounixM deleted the logs-functions branch April 4, 2024 05:36
@SagarRajput-7 SagarRajput-7 mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@nityanandagohain nityanandagohain nityanandagohain approved these changes

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YounixM @Rajat-Dabade @nityanandagohain @vikrantgupta25