feat: introducing collapsable rows for dashboards

[vikrantgupta25]

Summary

• added collapsable rows for dashboards

Related Issues / PR's

Fixes - #3571

Screenshots

Screen.Recording.2024-04-15.at.2.38.21.PM.mov

Affected Areas and Manually Tested Areas

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[srikanthccv]

Please see https://www.loom.com/share/26dc9964ad85422b89f526a5bcf35b89

[vikrantgupta25]

@srikanthccv thanks for the feedback, will check why the rearrangement is happening. For the delete and the rearrange thing we have two conscious decisions:-

1. We do not allow for re-arrangement of rows in a non-collapsed state as it contains the widgets tied to the row and we cannot move all of them together with the row so only a collapsed row can be moved.
2. We do not allow deletion in the case of a collapsed state as it causes two scenarios whether we delete the panels inside the row as well or we just delete the row. So to avoid this we just delete the row when the row is not collapsed and user is aware of what panels are inside the row and they will maintain their positions. Else we would cause a massive layout shift when the user deletes just the row in collapsed state and out of sudden a lot of panels will appear out.

[srikanthccv]

We do not allow for re-arrangement of rows in a non-collapsed state as it contains the widgets tied to the row and we cannot move all of them together with the row so only a collapsed row can be moved.

This makes sense

We do not allow deletion in the case of a collapsed state as it causes two scenarios whether we delete the panels inside the row as well or we just delete the row. So to avoid this we just delete the row when the row is not collapsed and user is aware of what panels are inside the row and they will maintain their positions. Else we would cause a massive layout shift when the user deletes just the row in collapsed state and out of sudden a lot of panels will appear out.

You could ask me(the user) whether to delete the row & panels or just delete the row in the confirmation step.

[vikrantgupta25]

You could ask me(the user) whether to delete the row & panels or just delete the row in the confirmation step.

This would be covered in phase2 of changes, had this in roadmap :)

[srikanthccv]

Ok, thanks for letting me know. It's fine as long as we plan to do it.

[srikanthccv]

LGTM. Please work with Prashant to plan for the rollout. We should make sure when this out the migration is also run.