fix: dont enrich if non empty keys are not same #4930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4901
Issue explaination
If there are two fields
We added a change recently where we forcefully try to enrich all attributes
so if user is searching for
myattr (type=resource, datatype=string)
then it might get replaced with* myattr (type=tag, datatype=string)
This PR fixes it.
though there is no solution right now if in the query user enters
myattr
with no metadata, we don't know which one to choose for enriching the tag or the resource attribute.