Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

True Wind when we do not have Log Speed #18

Closed
wants to merge 1 commit into from

Conversation

netAction
Copy link

No description provided.

@sbender9
Copy link
Member

sbender9 commented Nov 6, 2017

This is ground wind. It's already there.

@tkurki
Copy link
Member

tkurki commented Nov 6, 2017

This is based on sog, not stw.

@sbender9
Copy link
Member

sbender9 commented Nov 6, 2017

@tkurki
Copy link
Member

tkurki commented Nov 6, 2017

Oops, my mistake.

@netAction
Copy link
Author

netAction commented Nov 6, 2017

Yes, both this and groundWind.js use AWS, AWA, COG and SOG.

This returns wind direction over ground, useful for displays. Plus TWS and TWA which you need in wind gauges.

groundWind.js returns wind speed over ground and wind direction relative to heading. Don't know where you need them.

You are right, wind direction relative to heading is the same as TWA, but the returned variable names are all different.

@sbender9
Copy link
Member

sbender9 commented Nov 6, 2017

Sorry, you can't calculate TWA or TWS without STW. It should not be here.

If you need wind direction over ground, you should add that to groundWind.js.

@netAction
Copy link
Author

The whole pull request is about a fallback for the case that STW fails and we need to set STW=SOG.

In the derived data plugin there maybe should be a switch for this case. I tried stacking multiple calcs and it did not work. So I chose to calculate TWS and TWA directly.

@sbender9
Copy link
Member

sbender9 commented Nov 7, 2017

I don't like the idea of putting data into SignalK that claims to one thing, but is something else.

Why wouldn't you just use the correct paths to display GWS and GWA on the client if TWA and TWS are not available?

@netAction
Copy link
Author

Good question. This would be an issue for all wind gauges.

@sbender9 sbender9 closed this Nov 9, 2017
@netAction netAction mentioned this pull request Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants