-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zones-meta and Notification updates #664
base: master
Are you sure you want to change the base?
Conversation
| emergency | The value indicates a life-threatening condition | | ||
|
||
## Resolving and silencing notifications | ||
* To silence a notification, the serve or clients, send delta notification replica without the `sound` item the method array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actioning a notification is an operation of the notification manager.
As this applies to implementation, the expected operation should be outlined here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this yesterday, I was including Alarm Clearer plugin as a standard setup in this writing. What do you recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to be able to explain how consumers should work the system.
Can you write a larger summary of the changes? Really hard to parse and make sense of the diffs. |
Diff ignoring whitespace changes is better https://github.com/SignalK/specification/pull/664/files?w=1 |
There was no squash commit for some unknown reason. Maybe read from my fork here: Not sure how else to do it but pasting the whole thing here. Or I could create another branch with a single commit. |
The PR is based on that branch so there is no difference whether you look at the PR or the branch. If you don't squash then there is no squash, just your commits. But in terms of understanding what has changed squashing or the long list of commits with less than understandable commit messages is not the problem. You have made so many changes to line breaks without changing the content that it is needlessly hard to understand what are the meaningful changes. This is what Scott is asking - the PR description is pretty cryptic. So please can you summarise how and why this PR changes things? |
What do you suggest to fix this? I'm not sure how I can resubmit in one change without line breaks. I formatted so I could read myself. It's a learning curve. Thanks |
|
Notification changes
Metadata Changes
Please read the output as this is my first spec update. I wrote this based on my exchange with Scott and what I understood. I'm not without fault... I hope what I wrote helps! |
Update to change ffrom alarm to notification. Adjusted zones and operationnal concept.