Skip to content

Commit

Permalink
Removing extraneous call to IHttpClient.Initialize (#3830)
Browse files Browse the repository at this point in the history
An extraneous call to IHttpClient.Initialize when sending the start requests resets httpClients in the DefaultHttpClient. This may break load balancers and prevent reusing HTTPS connections (SSL negotation will happen twice - once for negotiate and once for start)

More: #3829
  • Loading branch information
moozzyk committed Dec 22, 2016
1 parent 6f5c68b commit 0b362f6
Showing 1 changed file with 0 additions and 2 deletions.
Expand Up @@ -57,8 +57,6 @@ public virtual Task<string> GetStartResponse(IHttpClient httpClient, IConnection


var startUrl = UrlBuilder.BuildStart(connection, transport, connectionData); var startUrl = UrlBuilder.BuildStart(connection, transport, connectionData);


httpClient.Initialize(connection);

return httpClient.Get(startUrl, connection.PrepareRequest, isLongRunning: false) return httpClient.Get(startUrl, connection.PrepareRequest, isLongRunning: false)
.Then(response => response.ReadAsString()); .Then(response => response.ReadAsString());
} }
Expand Down

3 comments on commit 0b362f6

@peters
Copy link

@peters peters commented on 0b362f6 Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moozzyk Any chance of a new release regarding this fix?

@moozzyk
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a date at this point but have already started thinking about a servicing release (2.2.2). Stay tuned.

@peters
Copy link

@peters peters commented on 0b362f6 Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.