fix #3459 by transferring perf counter values

when a connection hops transports, we don't properly transfer the connection in the perf counters; this change fixes that
SignalR · Jan 25, 2017 · 7241831 · 7241831
1 parent 0b362f6
commit 7241831
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Microsoft.AspNet.SignalR.sln b/Microsoft.AspNet.SignalR.sln
@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 14
-VisualStudioVersion = 14.0.24711.0
+VisualStudioVersion = 14.0.25420.1
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNet.SignalR.Core", "src\Microsoft.AspNet.SignalR.Core\Microsoft.AspNet.SignalR.Core.csproj", "{1B9A82C4-BCA1-4834-A33E-226F17BE070B}"
 EndProject

diff --git a/src/Microsoft.AspNet.SignalR.Core/Transports/TransportHeartBeat.cs b/src/Microsoft.AspNet.SignalR.Core/Transports/TransportHeartBeat.cs
@@ -87,6 +87,10 @@ public ITrackingConnection AddOrUpdateConnection(ITrackingConnection connection)
                 isNewConnection = false;
                 oldConnection = old.Connection;
 
+                // If the old connection was on a different transport, we need to transfer the count
+                old.Connection.DecrementConnectionsCount();
+                newMetadata.Connection.IncrementConnectionsCount();
+
                 return newMetadata;
             });