Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary work to allow server to support multiple protocol versions #2017

Closed
NTaylorMullen opened this issue May 13, 2013 · 3 comments
Closed

Preliminary work to allow server to support multiple protocol versions #2017

NTaylorMullen opened this issue May 13, 2013 · 3 comments
Assignees
@Xiaohongt
Labels
type: Feature
Milestone
2.0.0 Beta 1

Comments

@NTaylorMullen
Copy link
Contributor

Essentially new clients will now pass their expected protocol version via the Query String to the server. If the server does not get a version number it will default to 1.2. Otherwise it will return 1.3. This way the client will be able to determine if it supports a valid protocol version.
@ghost ghost assigned NTaylorMullen May 13, 2013
NTaylorMullen added a commit that referenced this issue May 14, 2013
@NTaylorMullen
Finished server side changes for protocol resolution
72cea88 
- Supports ranges for server protocols
- Also allows replacement of protocol resolver

#2017
NTaylorMullen added a commit that referenced this issue May 14, 2013
@NTaylorMullen
Updated protocol in JS client
6484975 
- Also added the feature to pass the clientProtocol in the negotiation request

#2017
NTaylorMullen added a commit that referenced this issue May 14, 2013
@NTaylorMullen
Updated protocol in C# client
c8c8a93 
- Also added the feature to pass the clientProtocol in the negotiation request

#2017
NTaylorMullen added a commit that referenced this issue May 14, 2013
@NTaylorMullen
Added tests to verify protocol handling on the server
6212aa9 
- Includes JS, C# Client, and Server
- Had to add a little bit of extensibility to the test utilities for JS to allow overriding of the WrapConnectionStart functionality

#2017
@NTaylorMullen NTaylorMullen mentioned this issue May 14, 2013
Closed
NTaylorMullen added a commit that referenced this issue May 15, 2013
@NTaylorMullen
Finished server side changes for protocol resolution
cf3fa81 
- Supports ranges for server protocols
- Also allows replacement of protocol resolver

#2017
NTaylorMullen added a commit that referenced this issue May 15, 2013
@NTaylorMullen
Updated protocol in JS client
25efb22 
- Also added the feature to pass the clientProtocol in the negotiation request

#2017
NTaylorMullen added a commit that referenced this issue May 15, 2013
@NTaylorMullen
Updated protocol in C# client
8a150ca 
- Also added the feature to pass the clientProtocol in the negotiation request

#2017
NTaylorMullen added a commit that referenced this issue May 15, 2013
@NTaylorMullen
Added tests to verify protocol handling on the server
56a5e4e 
- Includes JS, C# Client, and Server
- Had to add a little bit of extensibility to the test utilities for JS to allow overriding of the WrapConnectionStart functionality

#2017
NTaylorMullen added a commit that referenced this issue May 16, 2013
@NTaylorMullen
Finished server side changes for protocol resolution
d1f4e4b 
- Supports ranges for server protocols
- Also allows replacement of protocol resolver

#2017
NTaylorMullen added a commit that referenced this issue May 16, 2013
@NTaylorMullen
Updated protocol in JS client
2713fcc 
- Also added the feature to pass the clientProtocol in the negotiation request

#2017
NTaylorMullen added a commit that referenced this issue May 16, 2013
@NTaylorMullen
Updated protocol in C# client
1b622a7 
- Also added the feature to pass the clientProtocol in the negotiation request

#2017
NTaylorMullen added a commit that referenced this issue May 16, 2013
@NTaylorMullen
Added tests to verify protocol handling on the server
56bf068 
- Includes JS, C# Client, and Server
- Had to add a little bit of extensibility to the test utilities for JS to allow overriding of the WrapConnectionStart functionality

#2017
NTaylorMullen added a commit that referenced this issue May 17, 2013
@NTaylorMullen @davidfowl
Finished server side changes for protocol resolution
fa2a5ad 
- Supports ranges for server protocols
- Also allows replacement of protocol resolver

#2017
NTaylorMullen added a commit that referenced this issue May 17, 2013
@NTaylorMullen @davidfowl
Updated protocol in C# client
994210b 
- Also added the feature to pass the clientProtocol in the negotiation request

#2017
NTaylorMullen added a commit that referenced this issue May 17, 2013
@NTaylorMullen @davidfowl
Added tests to verify protocol handling on the server
b233f1b 
- Includes JS, C# Client, and Server
- Had to add a little bit of extensibility to the test utilities for JS to allow overriding of the WrapConnectionStart functionality

#2017
@davidfowl
Copy link
Member

@NTaylorMullen isn't this done?

@ghost ghost assigned Xiaohongt May 17, 2013
@NTaylorMullen
Copy link
Contributor Author

Just marked it correctly

@Xiaohongt
Copy link
Contributor

verified without querystring and with querystring for different values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiaohongt Xiaohongt

Labels
type: Feature
Projects
None yet
Milestone
2.0.0 Beta 1
Development

No branches or pull requests
3 participants
@davidfowl @NTaylorMullen @Xiaohongt