Hub calls should fail if request's response is 3xx redirect #2106

SteveSyfuhs · 2013-05-30T22:35:04Z

The client library should treat requests with responses with redirect codes (e.g. 302/301) as failed.

This is problematic in situations where browser sessions expire but the client library is still trying to call back -- e.g. via timer

setInterval(function() { // trivial example
     $.connection.myHub.server.getLatest().done(function(someResp) {
          updateSomething(someResp);
     }).fail(function() { 
          alert('bang'); 
     });
}, 90000); // 90 seconds

The observed behavior is that the request is made to the server, the server responds 302, the browser then does the redirect and requests the login page, but neither done() or fail() are called.

davidfowl · 2013-06-25T04:47:55Z

We'll fix this for 2.0

NTaylorMullen · 2013-07-02T22:26:35Z

I feel that a better approach would be to fail IF we are unable to parse the response body. This alternative is more of a general fail condition where if we're redirected to a page that is not valid JSON we can fail appropriately.

…hen an error occurs, instead of throwing to the window object we now handle it appropriately. #2106

…rifying parse responses is handled correctly when it throws. #2106

… error handler and stop the connection. #2106

…hen an error occurs, instead of throwing to the window object we now handle it appropriately. #2106

…rifying parse responses is handled correctly when it throws. #2106

… error handler and stop the connection. #2106

kbirger · 2013-07-17T14:06:44Z

Whatever was changed between 1.1.2 and 2.0.0 beta has caused some of the service resources like /xxxhub/signalr/connect to trigger forms authentication (without consulting the authorizeattribute on the hub -- which seems wrong to me). I'm not sure what it was, and I think it would be better if this was handled with a 401 and not a 302. One reason is that it seems to break IE9. Right now, IE is propagating the 302 to the entire page and redirecting me away from the page I'm trying to view.

NTaylorMullen · 2013-07-18T17:17:47Z

Moving this back into the working state, we need to special case requests that occur while in the connecting state to ensure if a redirect or some other parse error occurs during that time period that we fall back and not error->stop.

- If transports fail to parse a response while in connecting they will now fall back. - Centralized this logic in the common.js #2106

…hile connecting indeed do fall back. #2106

- If transports fail to parse a response while in connecting they will now fall back. - Centralized this logic in the common.js #2106

…hile connecting indeed do fall back. #2106

NTaylorMullen · 2013-07-18T23:38:02Z

@kbirger the latest change should fix your issue. As for the IE9 redirection I wasn't able to reproduce that issue.

gustavo-armenta · 2013-07-20T01:51:10Z

Verified OnError event is raised when request is redirected and the response content is not valid json

LP-Connect
SignalR: No transport could be initialized successfully. Try specifying a different transport or none at all for auto initialization.
LP-Poll
SignalR: failed at parsing response: . With error: Unexpected token <
LP-Send
SyntaxError: Unexpected token <

davidfowl · 2013-07-20T08:43:39Z

@gustavo-armenta did you test any auth scenarios?

gustavo-armenta · 2013-07-23T04:31:43Z

@davidfowl
I added a middleware to simulate invalid basic auth credentials during "/poll" and "/send"

map.Use((context, next) =>
{
    if (context.Request.Path.Contains("/poll") || context.Request.Path.Contains("/send"))
    {        
        if (++requestNumber % 2 > 0)
        {
            context.Request.Headers["Authorization"] = "Basic " + Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes("user:wrong_password"));
        }
    }

    return next.Invoke();
});

We are sending a response with 401, and the user is asked to input credentials again

HTTP/1.1 401 Unauthorized
Cache-Control: private
Transfer-Encoding: chunked
Content-Type: text/html; charset=utf-8
Server: Microsoft-IIS/8.0
WWW-Authenticate: Basic
X-AspNet-Version: 4.0.30319
X-SourceFiles: =?UTF-8?B?RDpcc2lnbmFsclxkZXZcc2FtcGxlc1xNaWNyb3NvZnQuQXNwTmV0LlNpZ25hbFIuU2FtcGxlc1xiYXNpY2F1dGhcc2lnbmFsclxwb2xs?=
X-Powered-By: ASP.NET
Date: Tue, 23 Jul 2013 04:27:06 GMT

67
<html><head><title>Authentication Failed</title></head><body>Invalid username or password</body></html>
0

davidfowl · 2013-07-23T04:45:05Z

Very nice. Can you try forms auth as well?

gustavo-armenta · 2013-07-24T19:08:40Z

I tried forms auth:
After signout, a websocket connection can still send messages successfully while the rest of transports fail to send message, get 302 redirection to login page, fail to parse JSON content as it is HTML, and disconnect the signalr client

ghost assigned davidfowl Jun 25, 2013

ghost assigned NTaylorMullen Jun 27, 2013

NTaylorMullen added a commit that referenced this issue Jul 8, 2013

Modified all instances of parseResponse to now have error handling. W…

a8bde97

…hen an error occurs, instead of throwing to the window object we now handle it appropriately. #2106

NTaylorMullen added a commit that referenced this issue Jul 8, 2013

Added tests to verify response redirection handling in addition to ve…

3729e25

…rifying parse responses is handled correctly when it throws. #2106

NTaylorMullen mentioned this issue Jul 8, 2013

2106 - Added error handling for invalid json responses #2268

Merged

NTaylorMullen added a commit that referenced this issue Jul 15, 2013

Whenever we fail at parsing a response from the server we trigger the…

f22d385

… error handler and stop the connection. #2106

NTaylorMullen added a commit that referenced this issue Jul 16, 2013

Modified all instances of parseResponse to now have error handling. W…

3c4adc0

…hen an error occurs, instead of throwing to the window object we now handle it appropriately. #2106

NTaylorMullen added a commit that referenced this issue Jul 16, 2013

Added tests to verify response redirection handling in addition to ve…

91b533b

…rifying parse responses is handled correctly when it throws. #2106

NTaylorMullen added a commit that referenced this issue Jul 16, 2013

Whenever we fail at parsing a response from the server we trigger the…

0aa0925

… error handler and stop the connection. #2106

NTaylorMullen mentioned this issue Jul 16, 2013

longPolling does not trigger start().fail when authorization fails #2288

Closed

ghost assigned muratg Jul 16, 2013

ghost assigned NTaylorMullen Jul 18, 2013

NTaylorMullen added a commit that referenced this issue Jul 18, 2013

Altered how the transports handled failed parsing cases.

9f72da5

- If transports fail to parse a response while in connecting they will now fall back. - Centralized this logic in the common.js #2106

NTaylorMullen added a commit that referenced this issue Jul 18, 2013

Added a test to verify that transports that fail to parse responses w…

0fb3751

…hile connecting indeed do fall back. #2106

NTaylorMullen mentioned this issue Jul 18, 2013

2106 - Altered how the transports handled failed parsing cases during the connecting phase. #2308

Merged

NTaylorMullen added a commit that referenced this issue Jul 18, 2013

Altered how the transports handled failed parsing cases.

f45df91

- If transports fail to parse a response while in connecting they will now fall back. - Centralized this logic in the common.js #2106

NTaylorMullen added a commit that referenced this issue Jul 18, 2013

Added a test to verify that transports that fail to parse responses w…

635dba7

…hile connecting indeed do fall back. #2106

ghost assigned gustavo-armenta Jul 18, 2013

gustavo-armenta closed this as completed Jul 24, 2013

halter73 mentioned this issue Sep 5, 2013

Hub calls should fail if request's response is 3xx redirect #2506

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hub calls should fail if request's response is 3xx redirect #2106

Hub calls should fail if request's response is 3xx redirect #2106

SteveSyfuhs commented May 30, 2013

davidfowl commented Jun 25, 2013

NTaylorMullen commented Jul 2, 2013

kbirger commented Jul 17, 2013

NTaylorMullen commented Jul 18, 2013

NTaylorMullen commented Jul 18, 2013

gustavo-armenta commented Jul 20, 2013

davidfowl commented Jul 20, 2013

gustavo-armenta commented Jul 23, 2013

davidfowl commented Jul 23, 2013

gustavo-armenta commented Jul 24, 2013

Hub calls should fail if request's response is 3xx redirect #2106

Hub calls should fail if request's response is 3xx redirect #2106

Comments

SteveSyfuhs commented May 30, 2013

davidfowl commented Jun 25, 2013

NTaylorMullen commented Jul 2, 2013

kbirger commented Jul 17, 2013

NTaylorMullen commented Jul 18, 2013

NTaylorMullen commented Jul 18, 2013

gustavo-armenta commented Jul 20, 2013

davidfowl commented Jul 20, 2013

gustavo-armenta commented Jul 23, 2013

davidfowl commented Jul 23, 2013

gustavo-armenta commented Jul 24, 2013