Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our self host depend on owin self host package #2291

Closed
davidfowl opened this issue Jul 14, 2013 · 4 comments
Closed

Make our self host depend on owin self host package #2291

davidfowl opened this issue Jul 14, 2013 · 4 comments
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

There's a new package Microsoft.Owin.SelfHost that we should take a dependency on in our self host package.

@Xiaohongt
Copy link
Contributor

With Owin release branch, when install or update Owin self host package, it will auto update existing Startup to below, and when uninstall Owin self host package, it will remove the Startup.
I will verify on Owin dev branch.

    public class Startup
    {
        public void Configuration(IAppBuilder app)
        {
#if DEBUG
            app.UseErrorPage();
#endif
            app.UseWelcomePage("/");
        }
    }

@Xiaohongt
Copy link
Contributor

same behavior on Owin dev branch

@davidfowl
Copy link
Member Author

Nice, I think we should make them remove the Startup.cs from the package.

@Xiaohongt
Copy link
Contributor

Verified that our self host has dependency Owin self host and Startup.ce is removed from Owin self host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants