Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rejoin groups on reconnect #525

Closed
davidfowl opened this Issue Jul 13, 2012 · 1 comment

Comments

Projects
None yet
4 participants
Owner

davidfowl commented Jul 13, 2012

Make this nice, e.g. have the override for OnReconnect return a bool indicating whether the connection should be added back to the groups they claim to be a member of. For Hubs, do the same thing.

Default the whole system to false, i.e. do not auto join connections to the groups they claim to be members of on reconnect.

@ghost ghost assigned DamianEdwards Jul 13, 2012

@ghost ghost assigned halter73 Aug 30, 2012

halter73 pushed a commit that referenced this issue Sep 19, 2012

Added OnRejoiningGroups to PersistentConnection
Fixes Issue #525

OnRejoiningGroups takes a list of groups a reconnecting client claims to be a
member of and returns a list of groups the client should actually rejoin.

The default implementation of OnRejoiningGroups always returns an empty
list of groups since the list of groups a client claims to be a member of
cannot be trusted.

Hub.RejoiningGroups is analogous to PersistentConnection.OnRejoiningGroups

halter73 pushed a commit that referenced this issue Sep 20, 2012

Added OnRejoiningGroups to PersistentConnection
Fixes Issue #525

OnRejoiningGroups takes a list of groups a reconnecting client claims to be a
member of and returns a list of groups the client should actually rejoin.

The default implementation of OnRejoiningGroups always returns an empty
list of groups since the list of groups a client claims to be a member of
cannot be trusted.

Hub.RejoiningGroups is analogous to PersistentConnection.OnRejoiningGroups
Contributor

Xiaohongt commented Oct 5, 2012

verified

@Xiaohongt Xiaohongt closed this Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment