Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rejoin groups on reconnect #525

Closed
davidfowl opened this issue Jul 13, 2012 · 1 comment
Closed

Rejoin groups on reconnect #525

davidfowl opened this issue Jul 13, 2012 · 1 comment
Assignees
@halter73
Labels
type: Feature
Milestone
1.0 Alpha 1

Comments

@davidfowl
Copy link
Member

Make this nice, e.g. have the override for OnReconnect return a bool indicating whether the connection should be added back to the groups they claim to be a member of. For Hubs, do the same thing.

Default the whole system to false, i.e. do not auto join connections to the groups they claim to be members of on reconnect.
@ghost ghost assigned DamianEdwards Jul 13, 2012
@ghost ghost assigned halter73 Aug 30, 2012
@halter73 halter73 mentioned this issue Sep 19, 2012
Closed
halter73 pushed a commit that referenced this issue Sep 19, 2012
Added OnRejoiningGroups to PersistentConnection
b975ee5 
Fixes Issue #525

OnRejoiningGroups takes a list of groups a reconnecting client claims to be a
member of and returns a list of groups the client should actually rejoin.

The default implementation of OnRejoiningGroups always returns an empty
list of groups since the list of groups a client claims to be a member of
cannot be trusted.

Hub.RejoiningGroups is analogous to PersistentConnection.OnRejoiningGroups
halter73 pushed a commit that referenced this issue Sep 20, 2012
Added OnRejoiningGroups to PersistentConnection
ce7baae 
Fixes Issue #525

OnRejoiningGroups takes a list of groups a reconnecting client claims to be a
member of and returns a list of groups the client should actually rejoin.

The default implementation of OnRejoiningGroups always returns an empty
list of groups since the list of groups a client claims to be a member of
cannot be trusted.

Hub.RejoiningGroups is analogous to PersistentConnection.OnRejoiningGroups
@Xiaohongt
Copy link
Contributor

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halter73 halter73

Labels
type: Feature
Projects
None yet
Milestone
1.0 Alpha 1
Development

No branches or pull requests
4 participants
@halter73 @davidfowl @DamianEdwards @Xiaohongt