Redirect connection.start to page load if needed #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the bugs fixed in this commit are duplicates. Executing Javascript once the DOM yielded constant loading in some browsers where they viewed the page as continuously loading since the entire page had not been loaded, even though the DOM had. Fixed this issue by re-routing the connection.start call to the window.load event by default but also allowing the user to overwrite the default via the startAfterPageLoad flag.
From startAfterPageLoad
Made deferral flag check more consistent. Fixed a comment to abide by consistency
Replaced all $(window) usages with the new saved referrence
NTaylorMullen
added a commit
that referenced
this pull request
Aug 4, 2012
Redirect connection.start to page load if needed
This was referenced Aug 4, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #215, #383 and #491
Executing Javascript once the DOM yielded constant loading in some
browsers where they viewed the page as continuously loading since the
entire page had not been loaded, even though the DOM had. Fixed this
issue by re-routing the connection.start call to the window.load event
by default but also allowing the user to overwrite the default via the
startAfterPageLoad flag.