1998 - Added a ping interval on the client to ensure authenticated users stay authenticated #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -328,6 +343,7 @@ | |||
| /// <param name="callback" type="Function">A callback function to execute when the connection has started</param> | |||
| var connection = this, | |||
| config = { | |||
| pingInterval: 300, | |||
There was a problem hiding this comment.
Aren't JS time spans always in milliseconds? 😄
…t expire when there's lack of activity. - This also involved adding a new configuration option 'pingInterval' which can be set via seconds
…ent configuration options in addition to multiple connection starts and stops.
- Changing an error message to not be prefixed with "SignalR:" and adding a log for it. - Added a failsafe to the ping server common utility so that if there is no transport defined we instantly reject the deferred (essentially nooping). - Removed the connection stop from a ping interval fail. - Modified the ping interval fail to use the new js error resources. - Removed the test that ensured that a failed ping interval would stop the connection. Updated errors to be signalr transport errors. Flowed the ping server fail to the connection error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user identity cannot change during an active SignalR connection #1998