Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2505 - Clear LP transport timeouts to prevent multiple connections with same CID #2599

Closed
wants to merge 60 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
e6a5d8f
Delete minified signalr JS client from repo
DamianEdwards Jul 19, 2013
5ac0c8c
Remove generated file from repo
DamianEdwards Jul 25, 2013
3be799e
Fixed new line issues with js tests.
davidfowl Sep 6, 2013
c1d3503
Don't capture the execution context when registering cancellation tok…
davidfowl Jun 27, 2013
4da11a4
Handle canceled tasks in the Subscription and MessageBroker.
davidfowl Jul 24, 2013
9b0ce1f
Recreate cursors when switching between default and scaleout scenarios
halter73 Jun 5, 2013
7479aaa
New tests for cursor prefixes
halter73 Jun 6, 2013
daf65a0
Use a random 4 bytes for cursor checksum for in DefaultSubscription.
davidfowl Sep 6, 2013
4665586
Fixed the unit tests to use the right prefix.
davidfowl Jul 22, 2013
393305a
Disable WebSocketHandler's max incoming message size on .NET client
davidfowl Sep 6, 2013
6dda782
Added isLongRunning flag to IHttpClient interface.
davidfowl Sep 6, 2013
7aea6ad
Use unique connection groups in .NET 4 client per IHttpClient instance
halter73 Aug 27, 2013
848b6a3
Only set connection group on desktop.
davidfowl Sep 6, 2013
a031b81
Fixed unobserved task on the server with websockets.
davidfowl Jul 31, 2013
73ac99b
Bump version to 1.1.5
halter73 Sep 10, 2013
02ce890
Delete another minified SignalR JS client from the repo
halter73 Sep 10, 2013
a3f1bf4
Added files to the new project made changes to Build.proj
abnanda1 Jul 9, 2013
e2a9dab
Moved files to appropriate test projects
abnanda1 Sep 13, 2013
ea88f3d
Stop using jQuery for managing the iframe in the foreverFrame transport
halter73 Sep 12, 2013
104b43b
Removed test that creates 50,000 XHRs
halter73 Sep 17, 2013
6ff0a85
Added logging to notify user when they do not subscribe to any hubs.
NTaylorMullen Sep 18, 2013
52b3a33
Added undefined param to JS
DamianEdwards Jul 31, 2013
dfd71d9
Made logging more consistent throughout the code base.
NTaylorMullen Jun 11, 2013
6151d1f
Fix Firefox not disconnecting on refresh
halter73 Sep 19, 2013
7f97baf
Make Firefox gracefully abort when a tab is closed
halter73 Sep 19, 2013
e3ffaf1
Added ajax defaults that are used to override any default ajax setups…
NTaylorMullen Sep 19, 2013
a755ba5
Added tests to verify the correctness of our ajax default overriding.
NTaylorMullen Sep 19, 2013
6aa61b0
Added retry logic to service bus when creation of subscription/topic …
abnanda1 Sep 23, 2013
3a502ac
Made changes to not throw exceptions in case of config, auth or messa…
abnanda1 Sep 19, 2013
137151a
Moved opening of the stream to after ProcessMessages
abnanda1 Sep 23, 2013
72e1b64
Removed restrictions on adding headers after connection has started
abnanda1 Jul 3, 2013
857ebc1
Added test to check that the user can set request headers after the c…
abnanda1 Sep 24, 2013
8e4d8aa
Made some formatting changes
abnanda1 Sep 24, 2013
1568fa6
Require the WebSocket Transport make an /abort request to abort
halter73 Jul 3, 2013
6cff50d
Made some websocket improvements.
davidfowl Aug 15, 2013
8536bc5
Catch and log errors on send.
davidfowl Aug 16, 2013
39212f6
Made some more changes to the WebSocketHandler and client websocket.
davidfowl Aug 16, 2013
08576ef
Make all DefaultWebSocketHandler operations noop after it's closed.
davidfowl Aug 23, 2013
e8f19e7
Added some websocket tests.
davidfowl Aug 21, 2013
b9ad1df
Made some websocket fixes.
halter73 Sep 20, 2013
7ba30b8
Made closed volatile
davidfowl Aug 24, 2013
500911e
ASP.NET does not support async void methods.
jcondex Aug 19, 2013
3236844
Handle errors thrown by the websocket transport loop.
davidfowl Aug 23, 2013
f47dbe6
Attach server-side WebSocket event handlers before receiving messages
halter73 Sep 24, 2013
ebf7295
Don't start the receive loop before OnConnected in OwinWebSocketHandler
halter73 Sep 24, 2013
8fd61a5
Modified the ping server to no longer special case websockets and to …
NTaylorMullen Sep 25, 2013
cd8aff8
issue #2485: WebSockets on Galaxy S3 Android Stock Browser
May 1, 2013
9b4f7f3
Added tests to verify that 401 and 403 status code responses from the…
NTaylorMullen Jul 29, 2013
a42875e
Fixed memory leak for 2413
jcondex Sep 11, 2013
d4879a3
Made changes based on feedback
jcondex Sep 11, 2013
7228134
Removed handling the QuotaExceededException separately since it is al…
abnanda1 Oct 1, 2013
01c6413
Removed timeout connecting check from server sent events start logic.
abnanda1 Oct 1, 2013
5715f12
Added checks to verify that we do not try and clear the foreverFrame …
NTaylorMullen Jul 17, 2013
3983bff
Added tests to verify that forever frame does not throw in start/stop…
NTaylorMullen Jul 17, 2013
d0051ca
Made logging more consistent throughout the code base.
NTaylorMullen Oct 3, 2013
b3e9564
Added a ping interval on the client to ensure that auth tickets do no…
NTaylorMullen Oct 2, 2013
08a7140
Added tests to verify that pingInterval behaves correctly with differ…
NTaylorMullen Oct 2, 2013
14218ee
Captured several long polling timeouts that are then cleared on stop.
NTaylorMullen Oct 1, 2013
b6f0c70
Added a test to verify that starting/stopping a connection while reco…
NTaylorMullen Jul 22, 2013
73a4f7b
Addressed code review comments.
NTaylorMullen Jul 25, 2013
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Expand Up @@ -30,3 +30,6 @@ tests/Microsoft.AspNet.SignalR.Client.JS.Tests/CommandLineBridge.js
*.vspx
*.log.txt
/tests/Microsoft.AspNet.SignalR.FunctionalTests/artifacts/
/samples/Microsoft.AspNet.SignalR.Client.WindowsStoreJavaScript.Samples/bld/
jquery.signalR.js
jquery.signalR.min.js
222 changes: 205 additions & 17 deletions Microsoft.AspNet.SignalR.sln

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion build/Build.proj
Expand Up @@ -81,6 +81,7 @@

<ItemGroup>
<UnitTestProjects Include="$(ProjectRoot)\tests\Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.csproj"></UnitTestProjects>
<UnitTestProjects Include="$(ProjectRoot)\tests\Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.csproj"></UnitTestProjects>
<UnitTestProjects Include="$(ProjectRoot)\tests\Microsoft.AspNet.SignalR.SqlServer.Tests\Microsoft.AspNet.SignalR.SqlServer.Tests.csproj"></UnitTestProjects>
</ItemGroup>

Expand Down Expand Up @@ -173,6 +174,10 @@
Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.Tests.XunitResults.xml"
Verbose="true" />

<xunit Assembly="$(ArtifactsDir)\Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.dll"
Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.Client.Tests.XunitResults.xml"
Verbose="true" />

<xunit Assembly="$(ArtifactsDir)\Microsoft.AspNet.SignalR.SqlServer.Tests\Microsoft.AspNet.SignalR.SqlServer.Tests.dll"
Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.SqlServer.Tests.XunitResults.xml"
Verbose="true" />
Expand Down Expand Up @@ -242,8 +247,9 @@
</Target>

<Target Name="UnitCodeCoverage" DependsOnTargets="PrepareCodeCoverage; BuildNetUnitTests">
<Copy SourceFiles="$(ProjectRoot)\build\Microsoft.AspNet.SignalR.UnitTests.OpenCover.xunit" DestinationFolder="$(ArtifactsDir)" />
<MSBuild Projects="Microsoft.AspNet.SignalR.OpenCover.targets"
Properties="ArtifactsDir=$(ArtifactsDir);SolutionDir=$(ProjectRoot)\;XunitArgs=Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.dll /noshadow"
Properties="ArtifactsDir=$(ArtifactsDir);SolutionDir=$(ProjectRoot)\;XunitArgs=$(ArtifactsDir)\Microsoft.AspNet.SignalR.UnitTests.OpenCover.xunit"
Condition="'$(OS)' == 'Windows_NT'"/>
</Target>

Expand Down
1 change: 1 addition & 0 deletions build/Microsoft.AspNet.SignalR.OpenCover.targets
Expand Up @@ -19,6 +19,7 @@
MergeByHash="True"
Filter="+[Microsoft.AspNet.SignalR*]*
-[Microsoft.AspNet.SignalR.Tests*]*
-[Microsoft.AspNet.SignalR.Client.Tests*]*
-[Microsoft.AspNet.SignalR.FunctionalTests*]*
-[Microsoft.AspNet.SignalR.Hosting.Memory*]*
-[Microsoft.AspNet.SignalR.TaskAsyncHelper]*"
Expand Down
1 change: 1 addition & 0 deletions build/Microsoft.AspNet.SignalR.OpenCover.xunit
Expand Up @@ -3,6 +3,7 @@
<assemblies>
<!-- NOTE: OpenCover requires shadow-copy to be false -->
<assembly filename="Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.dll" shadow-copy="false" />
<assembly filename="Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.dll" shadow-copy="false" />
<assembly filename="Microsoft.AspNet.SignalR.FunctionalTests\bin\Microsoft.AspNet.SignalR.FunctionalTests.dll" shadow-copy="false" />
</assemblies>
</xunit>
8 changes: 8 additions & 0 deletions build/Microsoft.AspNet.SignalR.UnitTests.OpenCover.xunit
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<xunit>
<assemblies>
<!-- NOTE: OpenCover requires shadow-copy to be false -->
<assembly filename="Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.dll" shadow-copy="false" />
<assembly filename="Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.dll" shadow-copy="false" />
</assemblies>
</xunit>
2 changes: 1 addition & 1 deletion build/Microsoft.AspNet.SignalR.versions.targets
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<MajorVersion>1</MajorVersion>
<MinorVersion>1</MinorVersion>
<PatchVersion>4</PatchVersion>
<PatchVersion>5</PatchVersion>

<!-- Change this to set the build quality of the project. Use values like "alpha", "beta", "rc1", "rtm", etc. -->
<!-- These values are used in SemVer, so make sure to always increase these alphabetically. -->
Expand Down
Expand Up @@ -242,6 +242,11 @@ public void MispelledClientMethod()
Clients.Caller.clientMethd();
}

public string ReturnLargePayload()
{
return new string('a', 64 * 1024);
}

public class Person
{
public string Name { get; set; }
Expand Down
@@ -1,5 +1,5 @@
/*!
* ASP.NET SignalR JavaScript Library v1.1.4
* ASP.NET SignalR JavaScript Library v1.1.5
* http://signalr.net/
*
* Copyright Microsoft Open Technologies, Inc. All rights reserved.
Expand All @@ -10,7 +10,7 @@

/// <reference path="..\..\SignalR.Client.JS\Scripts\jquery-1.6.4.js" />
/// <reference path="jquery.signalR.js" />
(function ($, window) {
(function ($, window, undefined) {
/// <param name="$" type="jQuery" />
"use strict";

Expand Down Expand Up @@ -234,6 +234,11 @@
return proxies.demo.invoke.apply(proxies.demo, $.merge(["ReadStateValue"], $.makeArray(arguments)));
},

returnLargePayload: function () {
/// <summary>Calls the ReturnLargePayload method on the server-side demo hub.&#10;Returns a jQuery.Deferred() promise.</summary>
return proxies.demo.invoke.apply(proxies.demo, $.merge(["ReturnLargePayload"], $.makeArray(arguments)));
},

setStateValue: function (value) {
/// <summary>Calls the SetStateValue method on the server-side demo hub.&#10;Returns a jQuery.Deferred() promise.</summary>
/// <param name=\"value\" type=\"String\">Server side type is System.String</param>
Expand Down