Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2505 - Clear LP transport timeouts to prevent multiple connections with same CID #2599

Closed
wants to merge 60 commits into from

Commits on Sep 10, 2013

  1. Configuration menu
    Copy the full SHA
    e6a5d8f View commit details
    Browse the repository at this point in the history
  2. Remove generated file from repo

    DamianEdwards authored and halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    5ac0c8c View commit details
    Browse the repository at this point in the history
  3. Fixed new line issues with js tests.

    davidfowl authored and halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    3be799e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c1d3503 View commit details
    Browse the repository at this point in the history
  5. Handle canceled tasks in the Subscription and MessageBroker.

    - Treat canceled tasks like faulted tasks.
    - Added another test to verify cancellation handling.
    davidfowl authored and halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    4da11a4 View commit details
    Browse the repository at this point in the history
  6. Recreate cursors when switching between default and scaleout scenarios

    - Achieve this by recreating cursors that don't have the appropriate prefix
    #2061
    halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    9b0ce1f View commit details
    Browse the repository at this point in the history
  7. New tests for cursor prefixes

    halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    7479aaa View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    daf65a0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4665586 View commit details
    Browse the repository at this point in the history
  10. Disable WebSocketHandler's max incoming message size on .NET client

    - Test that the .NET client can receive messages over 64KB via WebSockets
    - Fixup the tests so they run on 1.1.x
    
    #2495
    davidfowl authored and halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    393305a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6dda782 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7aea6ad View commit details
    Browse the repository at this point in the history
  13. Only set connection group on desktop.

    davidfowl authored and halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    848b6a3 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a031b81 View commit details
    Browse the repository at this point in the history
  15. Bump version to 1.1.5

    halter73 committed Sep 10, 2013
    Configuration menu
    Copy the full SHA
    73ac99b View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    02ce890 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2013

  1. Added files to the new project made changes to Build.proj

    #2258
    
    Conflicts:
    	build/Build.proj
    	tests/Microsoft.AspNet.SignalR.Client.CSharp.Tests/Client/ConnectionFacts.cs
    abnanda1 committed Sep 12, 2013
    Configuration menu
    Copy the full SHA
    a3f1bf4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2013

  1. Configuration menu
    Copy the full SHA
    e2a9dab View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2013

  1. Stop using jQuery for managing the iframe in the foreverFrame transport

    - Hopefully this will avoid "SCRIPT70: Permission denied" errors in IE
    
    #2508
    halter73 committed Sep 18, 2013
    Configuration menu
    Copy the full SHA
    ea88f3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    104b43b View commit details
    Browse the repository at this point in the history
  3. Added logging to notify user when they do not subscribe to any hubs.

    - Also added logging to show when a client subscribes to a hub.
    
    #2514
    NTaylorMullen committed Sep 18, 2013
    Configuration menu
    Copy the full SHA
    6ff0a85 View commit details
    Browse the repository at this point in the history
  4. Added undefined param to JS

    DamianEdwards authored and halter73 committed Sep 18, 2013
    Configuration menu
    Copy the full SHA
    52b3a33 View commit details
    Browse the repository at this point in the history
  5. Made logging more consistent throughout the code base.

    - Added periods to the end of every log line.
    - Removed "SignalR:" from beginning of logged lines so it wasn't logged twice.
    - Re-worded some language
    - Added Long poll complete log
    
    #2512
    NTaylorMullen committed Sep 18, 2013
    Configuration menu
    Copy the full SHA
    dfd71d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2013

  1. Fix Firefox not disconnecting on refresh

    - Change the withCredentials flag to only be auto-set when cross-domain is detected (can still be explicitly set)
    - Conditionally do an async abort if the browser is Firefox 11+ AND withCredentials is true
    #2489
    halter73 committed Sep 19, 2013
    Configuration menu
    Copy the full SHA
    6151d1f View commit details
    Browse the repository at this point in the history
  2. Make Firefox gracefully abort when a tab is closed

    - This change is only needed for cross-domain scenarios
    - This does not work when the entire browser window is closed
    #2517
    halter73 committed Sep 19, 2013
    Configuration menu
    Copy the full SHA
    7f97baf View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2013

  1. Added ajax defaults that are used to override any default ajax setups…

    … to prevent our ajax communications from failing.
    
    #2511
    NTaylorMullen committed Sep 20, 2013
    Configuration menu
    Copy the full SHA
    e3ffaf1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a755ba5 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2013

  1. Added retry logic to service bus when creation of subscription/topic …

    …or receiving of messages fails
    
    #2585
    abnanda1 committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    6aa61b0 View commit details
    Browse the repository at this point in the history
  2. Made changes to not throw exceptions in case of config, auth or messa…

    …ging errors in Service Bus
    
    #2542 #2541
    abnanda1 committed Sep 23, 2013
    Configuration menu
    Copy the full SHA
    3a502ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    137151a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2013

  1. Configuration menu
    Copy the full SHA
    72e1b64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    857ebc1 View commit details
    Browse the repository at this point in the history
  3. Made some formatting changes

    abnanda1 committed Sep 24, 2013
    Configuration menu
    Copy the full SHA
    8e4d8aa View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2013

  1. Require the WebSocket Transport make an /abort request to abort

    - Avoids timeouts being mistakenly registered as aborts
    - Unifies abort logic for all transports
    
    #2195 #1231
    
    #2500
    halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    1568fa6 View commit details
    Browse the repository at this point in the history
  2. Made some websocket improvements.

    davidfowl authored and halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    6cff50d View commit details
    Browse the repository at this point in the history
  3. Catch and log errors on send.

    davidfowl authored and halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    8536bc5 View commit details
    Browse the repository at this point in the history
  4. Made some more changes to the WebSocketHandler and client websocket.

    - Prevent double dispose on the client side WebSocketTransport.
    - Always close the websocket before cancelling the token on the server.
    davidfowl authored and halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    39212f6 View commit details
    Browse the repository at this point in the history
  5. Make all DefaultWebSocketHandler operations noop after it's closed.

    - Added tests that verify it noops after closing.
    - Made the WebSocket property internal to ensure it's not used by another other code.
    
    #2457
    davidfowl authored and halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    08576ef View commit details
    Browse the repository at this point in the history
  6. Added some websocket tests.

    davidfowl authored and halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    e8f19e7 View commit details
    Browse the repository at this point in the history
  7. Made some websocket fixes.

    - Create a new cts for each websocket created.
    halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    b9ad1df View commit details
    Browse the repository at this point in the history
  8. Made closed volatile

    davidfowl authored and halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    7ba30b8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    500911e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3236844 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f47dbe6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ebf7295 View commit details
    Browse the repository at this point in the history
  13. Modified the ping server to no longer special case websockets and to …

    …use the connection.url.
    
    - Also added a test to verify the fix.
    
    #2570
    NTaylorMullen committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    8fd61a5 View commit details
    Browse the repository at this point in the history
  14. issue #2485: WebSockets on Galaxy S3 Android Stock Browser

    Gustavo Armenta authored and halter73 committed Sep 25, 2013
    Configuration menu
    Copy the full SHA
    cd8aff8 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2013

  1. Added tests to verify that 401 and 403 status code responses from the…

    … server on pings will stop the connection.
    
    - This involved creating a StatusCodeConnection that will change the response status code based on a query string variable AND will respond with a specified status code.
    
    #2360
    NTaylorMullen authored and halter73 committed Sep 30, 2013
    Configuration menu
    Copy the full SHA
    9b4f7f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2013

  1. Fixed memory leak for 2413

    jcondex committed Oct 1, 2013
    Configuration menu
    Copy the full SHA
    a42875e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4879a3 View commit details
    Browse the repository at this point in the history
  3. Removed handling the QuotaExceededException separately since it is al…

    …so a MessagingException
    abnanda1 committed Oct 1, 2013
    Configuration menu
    Copy the full SHA
    7228134 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01c6413 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2013

  1. Added checks to verify that we do not try and clear the foreverFrame …

    …iframe DOM when we don't need to.
    
    - This involved adding a state check for connected and deleting the frame message count on transport stop.
    - Also added an iframeClearThreshold value to the forever frame transport to allow me to test it.
    
    #2494
    NTaylorMullen committed Oct 2, 2013
    Configuration menu
    Copy the full SHA
    5715f12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3983bff View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2013

  1. Made logging more consistent throughout the code base.

    - Added periods to the end of every log line.
    - Removed "SignalR:" from beginning of logged lines so it wasn't logged twice.
    - Re-worded some language.
    - Added Long poll complete log.
    - Made it so the clearing hub invocation log is only called if callbacks are available to be cleared.
    
    #2487
    NTaylorMullen committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    d0051ca View commit details
    Browse the repository at this point in the history
  2. Added a ping interval on the client to ensure that auth tickets do no…

    …t expire when there's lack of activity.
    
    - This also involved adding a new configuration option 'pingInterval' which can be set via milliseconds in the connection.start
    
    #2507
    NTaylorMullen committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    b3e9564 View commit details
    Browse the repository at this point in the history
  3. Added tests to verify that pingInterval behaves correctly with differ…

    …ent configuration options in addition to multiple connection starts and stops.
    
    - Also modified the existing tests which called ping interval by also passing in a transport (no longer need to do that).
    
    #2507
    NTaylorMullen committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    08a7140 View commit details
    Browse the repository at this point in the history
  4. Captured several long polling timeouts that are then cleared on stop.

    - Also added two fields to the private data field of a connection object.
    
    #2505
    NTaylorMullen committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    14218ee View commit details
    Browse the repository at this point in the history
  5. Added a test to verify that starting/stopping a connection while reco…

    …nnecting does not result in simultaneous polls attempting to connect.
    
    #2125
    NTaylorMullen committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    b6f0c70 View commit details
    Browse the repository at this point in the history
  6. Addressed code review comments.

    - Added an extra check after long polling error handler trigger to ensure that multiple connections do not occur.
    
    #2505
    NTaylorMullen committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    73a4f7b View commit details
    Browse the repository at this point in the history