Respond to bad requests with a 400 status code #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
. We just need to verify that all of the fallback works as it should (and it should).
| string tokenUserName = tokens.Length > 1 ? tokens[1] : String.Empty; | ||
| string userName = GetUserIdentity(context); | ||
|
|
||
| if (!String.Equals(tokenUserName, userName, StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| throw new InvalidOperationException(String.Format(CultureInfo.CurrentCulture, Resources.Error_UnrecognizedUserIdentity)); | ||
| message = String.Format(CultureInfo.CurrentCulture, Resources.Error_UnrecognizedUserIdentity); |
There was a problem hiding this comment.
Hitting this code path will now cause the client to stop due to the 403. I'm ok with this behavior but it is a behavior change nonetheless. This ok? @davidfowl @DamianEdwards
There was a problem hiding this comment.
Yeah that's perfectly fine. There's no recovering from this error anyway so stopping is the right thing.
|
|
- Previously bad requests caused PersistentConnection.ProcessRequest to throw resulting in a 500 - Respond with a 403 status code when the client changes identity - No longer throwing on bad requests reduces extraneous error logging #2450
- This should make it easier to filter out those traces #2450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resulting in a 500
Swallow some exceptions on the server so they don't get logged #2450