Added EXE support (for OWIN self-hosted SignalR hubs) #3827
Conversation
|
Hi @jcoutch, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@jcoutch, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
This doesn't need to be a flag really. |
|
Sorry I didn't respond right away. Primary reason I tossed it behind a flag was so it didn't affect existing behavior. I can remove the flag if it's not needed. |
|
@davidfowl - I removed the /exe flag, and made it the default behavior. |
| @@ -61,7 +61,9 @@ private void OutputHubs(string path, string url, string outputPath) | |||
| path = path ?? Directory.GetCurrentDirectory(); | |||
| url = url ?? "/signalr"; | |||
|
|
|||
| var assemblies = Directory.GetFiles(path, "*.dll", SearchOption.AllDirectories); | |||
| var assemblies = Directory.GetFiles(path, "*.exe", SearchOption.AllDirectories) | |||
There was a problem hiding this comment.
Should be Concat instead of Union since the items are already unique.
The Signalr.exe utility only scanned for DLL's. In the case of a self-hosted OWIN process, the hubs are generally part of the EXE. Added a /exe flag that will search EXE's first, followed by DLL's.