Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom SignalR error handling capability - Fixed #515 #585

Merged
merged 7 commits into from Aug 14, 2012

Commits on Aug 7, 2012

  1. Unwrapped thrown exceptions

    Developers were getting wrapped exceptions which were not very
    distinguishable and required a lot of digging to pull out the base
    exception which is the most relevant piece.
    NTaylorMullen committed Aug 7, 2012
    Copy the full SHA
    cfdd04c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2012

  1. Added custom SignalR error handling capability

    Fixed #515
    
    Created an ErrorExtensions class to add a "GetError" capability to
    Exceptions.  GetError returns an error of type SignalRError which
    unwraps and pulls unique attributes out of a thrown exception to expose
    essential pieces to errors.
    NTaylorMullen committed Aug 8, 2012
    Copy the full SHA
    b590bb0 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2012

  1. Copy the full SHA
    ad6a1f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2012

  1. Addressed PR comments

    Made the SignalRError object disposable to assure no memory is leaked
    via the HttpWebResponse associated with WebExceptions
    NTaylorMullen committed Aug 13, 2012
    Copy the full SHA
    7a83108 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    35f252d View commit details
    Browse the repository at this point in the history
  3. Pointed unit test url to new URL

    The prior URL was pointing to localhost and if an IIS server was not
    running the machine would actively refuse the connection, resulting in a
    failure of the test (not a 404).
    NTaylorMullen committed Aug 13, 2012
    Copy the full SHA
    a2bdf66 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    c414a16 View commit details
    Browse the repository at this point in the history