Improve Key Validation and Handling in Overwrite Memory and Message Agent Functions #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also PR #105 |
suamai
reviewed
Apr 5, 2023
scripts/commands.py
Outdated
| elif isinstance(key, str): | ||
| _text = "Overwriting memory with key " + key + " and string " + string | ||
| # Overwrite the memory slot with the given string key and string | ||
| mem.string_key_memory[key] = string |
There was a problem hiding this comment.
What is the point of saving on this attribute if it is not used anywhere else?
There was a problem hiding this comment.
SYSTEM: Command memory_ovr returned: Error: module 'memory' has no attribute 'string_key_memory'
More importantly, that doesn't even seem to be an existing attribute.
Torantulino
requested changes
Apr 6, 2023
Fixes: ```Command memory_ovr returned: Error: module 'memory' has no attribute 'string_key_memory'```
Torantulino
requested changes
Apr 6, 2023
Torantulino
approved these changes
Apr 6, 2023
Closed
|
Fixes #90 |
Say383
pushed a commit
to Say383/Auto-GPT
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to key validation and handling in the
overwrite_memoryandmessage_agentfunctions within thescripts/commands.pyfile.Changes include:
is_valid_intto check if a value can be converted to an integer.overwrite_memoryfunction to handle both integer and string keys, and providing more informative error messages.message_agentfunction to use theis_valid_inthelper function for key validation and providing an informative error message for invalid keys.These changes aim to make the code more robust and user-friendly, allowing for better handling of different key types and more informative error messages when invalid keys are encountered.