Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The key of the agent manager is converted to str, simplifying the code #2311

Conversation

lengweiping1983
Copy link
Contributor

@lengweiping1983 lengweiping1983 commented Apr 18, 2023

Background

The following is about the key type of the agent manager.

There are many ways to write the key type in the code:

  1. str
  2. str | int
  3. Union[str, int]
    and conversion is required in use.

The key type of the agent manager is change to str, simplifying the code, only use str and not required conversion.

Changes

The key type of the agent manager is change to str.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@nponeccop
Copy link
Contributor

@lengweiping1983 Thank you for your contributions to the project! If you ever feel that your pull requests need attention, please feel free to reach out to our merging team directly on our Discord channel. We're constantly working to improve the merging process, such as adding features like the conflict notification bot. We apologize for any inconvenience caused by the early bug in the bot, which led to multiple notifications for some users.

I also noticed that you've closed a few pull requests without leaving comments. To ensure better communication and understanding, it would be helpful if you could kindly leave a brief note explaining your decision when closing a request. In cases where pull requests are closed abruptly, we assign @BillSchumacher to review them and determine if they can be salvaged. By leaving a comment, you can help us avoid any confusion and allow @BillSchumacher to focus on other tasks. If you're planning to redo a pull request from scratch, letting us know would be greatly appreciated. Thanks again for your efforts, and we look forward to your continued contributions!

nponeccop
nponeccop previously approved these changes Apr 19, 2023
@nponeccop nponeccop added the B8 label Apr 19, 2023
@lengweiping1983
Copy link
Contributor Author

The reason for closing is that each pull request does not start from the master branch again, which may cause trouble for your review, so the pull request is resubmitted after decomposition.

I'll pay attention next time.

@lengweiping1983
Copy link
Contributor Author

@lengweiping1983 Thank you for your contributions to the project! If you ever feel that your pull requests need attention, please feel free to reach out to our merging team directly on our Discord channel. We're constantly working to improve the merging process, such as adding features like the conflict notification bot. We apologize for any inconvenience caused by the early bug in the bot, which led to multiple notifications for some users.

I also noticed that you've closed a few pull requests without leaving comments. To ensure better communication and understanding, it would be helpful if you could kindly leave a brief note explaining your decision when closing a request. In cases where pull requests are closed abruptly, we assign @BillSchumacher to review them and determine if they can be salvaged. By leaving a comment, you can help us avoid any confusion and allow @BillSchumacher to focus on other tasks. If you're planning to redo a pull request from scratch, letting us know would be greatly appreciated. Thanks again for your efforts, and we look forward to your continued contributions!

@nponeccop

I saw the code in the script of cli.py (called main.py yesterday), as follows:

    ai_name = ""

    other code ......	
    
    agent = Agent(
        ai_name=ai_name,
        memory=memory,
        full_message_history=full_message_history,

Where is the value of the ai_name variable obtained, it cannot be seen here,so I want optimize the code,
Make code more readable, more stable, and more robust.

Currently only one of them is optimized,

#2367

please review.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 19, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

1 similar comment
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 20, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

Coverage report

The coverage rate went from 33.74% to 33.74% ➡️
The branch rate is 21%.

55.55% of new lines are covered.

Diff Coverage details (click to unfold)

autogpt/agent/agent_manager.py

62.5% of new lines are covered (12.84% of the complete file).
Missing lines: 59, 83, 142

autogpt/app.py

0% of new lines are covered (21.64% of the complete file).
Missing lines: 217

@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@p-i- p-i- removed the B8 label May 16, 2023
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 25, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Pwuts
Copy link
Member

Pwuts commented Jul 7, 2023

Thanks, this caused us quite a bit of issues earlier. The AgentManager has since been deprecated while we work on a new structure for dispatching (fully-featured) sub-agents. Stay tuned! :)

@Pwuts Pwuts closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants