Fix duckduckgo rate limiting #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4592 +/- ##
==========================================
+ Coverage 69.52% 69.57% +0.04%
==========================================
Files 72 72
Lines 3551 3556 +5
Branches 569 569
==========================================
+ Hits 2469 2474 +5
Misses 892 892
Partials 190 190
☔ View full report in Codecov by Sentry. |
waynehamadi
force-pushed
the
fix-duckduckgo-rate-limiting
branch
from
d1bf94b
to
d4404ba
Compare
|
does that mean that the issue goes entirely away if we mock/cache DDG queries ? |
|
@Boostrix for information retrieval yes. I am not saying flakiness is gone. |
Pwuts
reviewed
Jun 6, 2023
|
The docs of the client library say to wait 0.75s between pages, which may be an indication that there is a minimum interval between requests. |
Co-authored-by: Reinier van der Leer <github@pwuts.nl>
|
Deployment failed with the following error: |
Pwuts
approved these changes
Jun 6, 2023
lc0rp
added a commit
that referenced
this pull request
Jun 19, 2023
Co-authored-by: Reinier van der Leer <github@pwuts.nl> Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: Nicholas Tindle <nicktindle@outlook.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> Co-authored-by: Merwane Hamadi <merwanehamadi@gmail.com> Co-authored-by: Richard Beales <rich@richbeales.net> Co-authored-by: Luke K <2609441+lc0rp@users.noreply.github.com> Co-authored-by: Luke K (pr-0f3t) <2609441+lc0rp@users.noreply.github.com> Co-authored-by: Erik Peterson <e@eriklp.com> Co-authored-by: Auto-GPT-Bot <github-bot@agpt.co> Co-authored-by: Benny van der Lans <49377421+bfalans@users.noreply.github.com> Co-authored-by: Jan <jan-github@phobia.de> Co-authored-by: Robin Richtsfeld <robin.richtsfeld@gmail.com> Co-authored-by: Marc Bornträger <marc.borntraeger@gmail.com> Co-authored-by: Stefan Ayala <stefanayala3266@gmail.com> Co-authored-by: javableu <45064273+javableu@users.noreply.github.com> Co-authored-by: DGdev91 <DGdev91@users.noreply.github.com> Co-authored-by: Kinance <kinance@gmail.com> Co-authored-by: digger yu <digger-yu@outlook.com> Co-authored-by: David <scenaristeur@gmail.com> Co-authored-by: gravelBridge <john.tian31@gmail.com> Fix Python CI "update cassettes" step (#4591) fix CI (#4596) Fix inverted logic for deny_command (#4563) fix current_score.json generation (#4601) Fix duckduckgo rate limiting (#4592) Fix debug code challenge (#4632) Fix issues with information retrieval challenge a (#4622) fix issues with env configuration and .env.template (#4630) Fix prompt issue causing 'No Command' issues and challenge to fail (#4623) Fix benchmark logs (#4653) Fix typo in docs/setup.md (#4613) Fix run.sh shebang (#4561) Fix autogpt docker image not working because missing prompt_settings (#4680) Fix execute_command coming from plugins (#4730)
jordankanter
pushed a commit
to jordankanter/Auto-GPT
that referenced
this pull request
Nov 12, 2023
* Fix duckduckgo rate limiting * use list instead of loop --------- Co-authored-by: Reinier van der Leer <github@pwuts.nl>
jordankanter
pushed a commit
to jordankanter/Auto-GPT
that referenced
this pull request
Nov 12, 2023
* Fix duckduckgo rate limiting * use list instead of loop --------- Co-authored-by: Reinier van der Leer <github@pwuts.nl>
jordankanter
pushed a commit
to jordankanter/Auto-GPT
that referenced
this pull request
Nov 12, 2023
* Fix duckduckgo rate limiting * use list instead of loop --------- Co-authored-by: Reinier van der Leer <github@pwuts.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
DuckDuckGo is rate limiting us by returning empty arrays. So our challenges are now flaky.
Changes
Retrial mechanism:
**I know it's weird that duckduckgo returns an empty generator when we get rate limited, but I didn't find any information that proves the opposite. If someone finds something let me know.
The problem
Documentation
Test Plan
PR Quality Checklist