-
Notifications
You must be signed in to change notification settings - Fork 44.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prompt issue causing 'No Command' issues and challenge b to fail #4623
Fix prompt issue causing 'No Command' issues and challenge b to fail #4623
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a39c03f
to
e5a3456
Compare
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
e5a3456
to
98fd355
Compare
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
83e9756
to
144dd67
Compare
You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4623 +/- ##
=======================================
Coverage 69.57% 69.57%
=======================================
Files 72 72
Lines 3583 3583
Branches 573 573
=======================================
Hits 2493 2493
Misses 899 899
Partials 191 191
☔ View full report in Codecov by Sentry. |
Co-authored-by: Reinier van der Leer <github@pwuts.nl> Co-authored-by: Nicholas Tindle <nick@ntindle.com> Co-authored-by: Nicholas Tindle <nicktindle@outlook.com> Co-authored-by: k-boikov <64261260+k-boikov@users.noreply.github.com> Co-authored-by: merwanehamadi <merwanehamadi@gmail.com> Co-authored-by: Merwane Hamadi <merwanehamadi@gmail.com> Co-authored-by: Richard Beales <rich@richbeales.net> Co-authored-by: Luke K <2609441+lc0rp@users.noreply.github.com> Co-authored-by: Luke K (pr-0f3t) <2609441+lc0rp@users.noreply.github.com> Co-authored-by: Erik Peterson <e@eriklp.com> Co-authored-by: Auto-GPT-Bot <github-bot@agpt.co> Co-authored-by: Benny van der Lans <49377421+bfalans@users.noreply.github.com> Co-authored-by: Jan <jan-github@phobia.de> Co-authored-by: Robin Richtsfeld <robin.richtsfeld@gmail.com> Co-authored-by: Marc Bornträger <marc.borntraeger@gmail.com> Co-authored-by: Stefan Ayala <stefanayala3266@gmail.com> Co-authored-by: javableu <45064273+javableu@users.noreply.github.com> Co-authored-by: DGdev91 <DGdev91@users.noreply.github.com> Co-authored-by: Kinance <kinance@gmail.com> Co-authored-by: digger yu <digger-yu@outlook.com> Co-authored-by: David <scenaristeur@gmail.com> Co-authored-by: gravelBridge <john.tian31@gmail.com> Fix Python CI "update cassettes" step (#4591) fix CI (#4596) Fix inverted logic for deny_command (#4563) fix current_score.json generation (#4601) Fix duckduckgo rate limiting (#4592) Fix debug code challenge (#4632) Fix issues with information retrieval challenge a (#4622) fix issues with env configuration and .env.template (#4630) Fix prompt issue causing 'No Command' issues and challenge to fail (#4623) Fix benchmark logs (#4653) Fix typo in docs/setup.md (#4613) Fix run.sh shebang (#4561) Fix autogpt docker image not working because missing prompt_settings (#4680) Fix execute_command coming from plugins (#4730)
Background
There have been an incredible number of tickets surrounding results not including a command- either
None
or an empty string. This was a cause (but probably not the only cause) of the Invalid JSON errors that are very commonly reported.I think the root cause of it is that in our triggering prompt we weren't clear that we required a command. In this change, it's clear that we need exactly one command. Testing manually it works great for me. This change also met the
information_retrieval_challenge_b
challenge that was previously disabled.See:
#21
#1407
and all of the tickets that are mentioned
Changes
Documentation
Test Plan
PR Quality Checklist