Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Re-arch]: List Files Ability #4791

Closed
wants to merge 140 commits into from
Closed

[Re-arch]: List Files Ability #4791

wants to merge 140 commits into from

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Jun 25, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

collijk and others added 30 commits May 2, 2023 16:55
* Update planner´s base.py

* improving based on comments

* added_selffeedback

* improving_docstring_and_interface

* improved_data_classes_and_feedback_fn

* docstring
* initial logging interface

* imports

* metadata
* Initial base.py for message broker

* type_enum

* fixing_imports

* classes_added
* re-arch: Initial BudgetManager impl

* separate base abc from concrete example

* init needs to accept kwargs
* First version of implementation for command base class

* Update PR comments

---------

Co-authored-by: Daryl Rodrigo <daryl@orkestro.com>
* Added in a click  entry point and status report

* renamed app_sketch to runner

* Fixing imports adding run commands for the client and server

* Make status display a little more formal and flexible

---------

Co-authored-by: James Collins <collijk@uw.edu>
* Revise message broker interface

* Add emitter

* This is the last change for a bit, I think

* Incorporate feedback
* feat: plugin base

* fix: formatting

---------

Co-authored-by: James Collins <collijk@uw.edu>
@ntindle
Copy link
Member Author

ntindle commented Jun 25, 2023

@collijk One thing I noticed is data isn't actually part of an ability result. Wanted to point that out

@ntindle ntindle requested a review from collijk June 25, 2023 19:39
@ntindle
Copy link
Member Author

ntindle commented Jun 25, 2023

@collijk Do we want to restrict to workspace only?

@ntindle ntindle mentioned this pull request Jun 25, 2023
@ntindle
Copy link
Member Author

ntindle commented Jun 25, 2023

related in #4770

@@ -84,7 +84,7 @@ def __call__(self, filename: str) -> AbilityResult:

class WriteFile(Ability):
default_configuration = AbilityConfiguration(
packages_required=["unstructured"],
packages_required=["os"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need builtin packages here.


class ListFiles(Ability):
default_configuration = AbilityConfiguration(
packages_required=["os"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@collijk
Copy link
Contributor

collijk commented Jun 26, 2023

@collijk One thing I noticed is data isn't actually part of an ability result. Wanted to point that out

Feel free to add. I haven't dug into knowledge summarization yet so haven't had to use it.

@collijk
Copy link
Contributor

collijk commented Jun 26, 2023

@collijk Do we want to restrict to workspace only?

The workspace should be managing that (and it's user configurable)

Base automatically changed from re-arch/hello-world to master July 5, 2023 19:12
@collijk collijk requested a review from a team as a code owner July 5, 2023 19:12
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jul 5, 2023
@collijk collijk self-assigned this Jul 14, 2023
@Pwuts Pwuts closed this Jan 29, 2024
@Pwuts Pwuts deleted the re-arch/files-list branch January 29, 2024 17:19
@Pwuts Pwuts restored the re-arch/files-list branch January 29, 2024 17:19
@Pwuts Pwuts deleted the re-arch/files-list branch January 29, 2024 17:19
@Pwuts
Copy link
Member

Pwuts commented Jan 29, 2024

Branch deleted for security reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

8 participants