Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required env parameters for azure usage #700

Merged

Conversation

Rokniel
Copy link
Contributor

@Rokniel Rokniel commented Apr 10, 2023

Background

Related to issue #657. Azure openAI uses multiple separate deployments for chat, embeddings and general "AI". These deployments must be specifically called for functionality.

Changes

Two new parameters have been added to the env file. One for embedding deployment and one for chat. The parameters are accessible from config.py within the use_azure=true block. llm_utils.py and memory/base.py have been changed to use these parameters if use_azure=true

Documentation

Additional parameters are described in readme.md under the Installation header within the If you want to use Azure -block.

Test Plan

Tested general functionality against our azure openai deployments. With the parameters in place, it works appears to work identically to a openAI API config

PR Quality Checklist

  • [x ] My pull request is atomic and focuses on a single change.
  • [x ] I have thouroughly tested my changes with multiple different prompts.
  • [x ] I have considered potential risks and mitigations for my changes.
  • [ x] I have documented my changes clearly and comprehensively.
  • [x ] I have not snuck in any "extra" small tweaks changes

nponeccop
nponeccop previously approved these changes Apr 10, 2023
@nponeccop nponeccop mentioned this pull request Apr 10, 2023
1 task
@nponeccop
Copy link
Contributor

@Rokniel There are conflicts again due to the merging of other PRs

@Rokniel
Copy link
Contributor Author

Rokniel commented Apr 11, 2023

Fixed the conflicts. Changed the naming to follow the new master branch naming changes

@sweetlilmre
Copy link
Contributor

Also fixed in #802 seems to be the same implementation.

sweetlilmre added a commit to sweetlilmre/Auto-GPT that referenced this pull request Apr 12, 2023
updated README.md to explain new config
added Azure yaml loader to config class
centralized model retrieval into config class
this commit effectively combines and replaces Significant-Gravitas#700 and Significant-Gravitas#580
@sweetlilmre sweetlilmre mentioned this pull request Apr 12, 2023
5 tasks
@richbeales richbeales merged commit 9c9758c into Significant-Gravitas:master Apr 12, 2023
@Rokniel Rokniel deleted the azure-deployment-additions branch April 12, 2023 20:34
EdwardYuan pushed a commit to EdwardYuan/Auto-GPT that referenced this pull request Apr 13, 2023
updated README.md to explain new config
added Azure yaml loader to config class
centralized model retrieval into config class
this commit effectively combines and replaces Significant-Gravitas#700 and Significant-Gravitas#580
korla-plankton pushed a commit to korla-plankton/Auto-GPT that referenced this pull request Apr 14, 2023
updated README.md to explain new config
added Azure yaml loader to config class
centralized model retrieval into config class
this commit effectively combines and replaces Significant-Gravitas#700 and Significant-Gravitas#580
SquareandCompass pushed a commit to SquareandCompass/Auto-GPT that referenced this pull request Oct 21, 2023
…/github_actions/actions/setup-python-4

Bump actions/setup-python from 2 to 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants